Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603197

Re: Does braille console work?

Show all headers | View raw

On 03/17/2017 03:53 AM, Samuel Thibault wrote:
> Hello,
> 
> Aleksey Makarov, on jeu. 16 mars 2017 17:02:53 +0300, wrote:
>> There can be 3 outcomes from this function:
>> 1) it returns NULL and does not set brl_options
>> 2) it returns NULL and set the variable pointed by str to NULL
>> 3) it returns non-NULL
> 
> Uh, that's odd indeed, the intent was that it'd return an error code
> only.
> 
>> To register a braille console (i. e. to call __add_preferred_console()
>> with non-NULL brl_options) function _braille_console_setup() should
>> return NULL and initialize brl_options. 
> 
> return 0 (as in no error), actually, in the intent.
> 
>> 1) in this case brl_options is NULL and non-braille console is registered
>> 2) kernel produces oops later in console_setup().  I reproduced it
>>    passing "console=brl=aaa" parameter to kernel, see below.
>> 3) no console is registered
>>
>> So braille console registration should not work.  What do I miss?
> 
> Nothing, the code transformation was broken :/

So the kernel contains seemingly unmaintained code that does not work
for at least 3 years.  Its parts in printk.c considerably complicate
code support.

>> So it looks like braille console has not been used for more than 3 years.
>> Should we remote it?
> 
> Please, no :)
> 
> It is indeed not often useful, since one would usually use a userland
> daemon to access the system, but when one's system does not boot
> properly or something similar, it's useful to have the braille
> console. That's just very not often useful.

Why should we keep the code which does not work?  And which is used
more than 3 years ago and usage requires patching.
I think removing it is a good idea

Thank you
Aleksey Makarov

> Samuel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Does braille console work? Aleksey Makarov <aleksey.makarov@linaro.org> - 2017-03-16 15:10 +0100
  Re: Does braille console work? Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-17 02:00 +0100
    Re: Does braille console work? Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-17 10:20 +0100
    Re: Does braille console work? Petr Mladek <pmladek@suse.com> - 2017-03-17 10:40 +0100
      Re: Does braille console work? Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-17 10:50 +0100
        Re: Does braille console work? Steven Rostedt <rostedt@goodmis.org> - 2017-03-17 14:10 +0100
          Re: Does braille console work? Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-19 15:50 +0100
    Re: Does braille console work? Aleksey Makarov <amakarov.linux@gmail.com> - 2017-03-17 12:10 +0100

csiph-web