Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603057

Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put

Show all headers | View raw

On Fri, Mar 17, 2017 at 03:11:37PM +0900, Greg Kroah-Hartman wrote:
> On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote:
> > Hey,
> > 
> > I think I see the issue here: in a couple of error conditions, the RTC
> > code will not initialize and ask for the cdev. However, my change will
> > always call cdev_add and cdev_del even though the rtc code did not call
> > cdev_init. I'll have to add a guard around dev->devt in the new
> > cdev_device functions. I'll prepare another patch tomorrow.
> > 
> > I also noticed that I neglected to remove the prototypes for the two RTC
> > function I removed. I'll fix that too.
> 
> Ok, I'm just going to drop this series from my tree so that other
> patches in it can get pushed out to linux-next.  Please resend the full
> series after you have fixed it up, and I'll be glad to queue it up
> again.

Also, when you resend, if you can collect the acks from the subsystem
maintainers, and add them to the patches, that would be very good.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690  kobject_put Logan Gunthorpe <logang@deltatee.com> - 2017-03-17 06:30 +0100
  Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690  kobject_put Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-17 07:20 +0100
    Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690  kobject_put Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-17 07:20 +0100

csiph-web