Re: [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4

From	Balbir Singh <bsingharora@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4
Date	2017-03-17 04:50 +0100
Message-ID	<tlR3P-8qq-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <tlFm1-cU-1@gated-at.bofh.it> <tlMQx-5vf-5@gated-at.bofh.it> <tlNWh-6eK-1@gated-at.bofh.it> <tlOpj-6qV-1@gated-at.bofh.it> <tlOyZ-6K6-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> Or make the HMM Kconfig feature 64BIT only by making it depend on 64BIT?
>>
>
> Yes, that was my first reaction too, but these particular routines are
> aspiring to be generic routines--in fact, you have had an influence there,
> because these might possibly help with NUMA migrations. :)
>

Yes, I still stick to them being generic, but I'd be OK if they worked
just for 64 bit systems.
Having said that even the 64 bit works version work for upto physical
sizes of 64 - PAGE_SHIFT
which is a little limiting I think.

One option is to make pfn's unsigned long long and do 32 and 64 bit computations
separately

Option 2, could be something like you said

a. Define a __weak migrate_vma to return -EINVAL
b. In a 64BIT only file define migrate_vma

Option 3

Something totally different

If we care to support 32 bit we go with 1, else option 2 is a good
starting point. There might
be other ways of doing option 2, like you've suggested

Balbir

Thread

[HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4 Jérôme Glisse <jglisse@redhat.com> - 2017-03-16 16:20 +0100
  Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 Reza Arbab <arbab@linux.vnet.ibm.com> - 2017-03-16 17:30 +0100
    Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 Balbir Singh <bsingharora@gmail.com> - 2017-03-16 22:40 +0100
  Re: [HMM 07/16] mm/migrate: new memory migration helper for use  with device memory v4 Andrew Morton <akpm@linux-foundation.org> - 2017-03-17 00:20 +0100
    Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 John Hubbard <jhubbard@nvidia.com> - 2017-03-17 01:30 +0100
      Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 Balbir Singh <bsingharora@gmail.com> - 2017-03-17 02:00 +0100
        Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 John Hubbard <jhubbard@nvidia.com> - 2017-03-17 02:10 +0100
          Re: [HMM 07/16] mm/migrate: new memory migration helper for use  with device memory v4 Jerome Glisse <jglisse@redhat.com> - 2017-03-17 03:10 +0100
            Re: [HMM 07/16] mm/migrate: new memory migration helper for use  with device memory v4 Andrew Morton <akpm@linux-foundation.org> - 2017-03-17 04:40 +0100
          Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 Balbir Singh <bsingharora@gmail.com> - 2017-03-17 04:50 +0100
            Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 Balbir Singh <bsingharora@gmail.com> - 2017-03-17 06:00 +0100
              Re: [HMM 07/16] mm/migrate: new memory migration helper for use with  device memory v4 John Hubbard <jhubbard@nvidia.com> - 2017-03-17 08:30 +0100

csiph-web