Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603009

Re: [f2fs-dev] [PATCH 2/2] f2fs: don't allow atomic writes for not regular files

From Chao Yu <yuchao0@huawei.com>
Newsgroups linux.kernel
Subject Re: [f2fs-dev] [PATCH 2/2] f2fs: don't allow atomic writes for not regular files
Date 2017-03-17 04:30 +0100
Message-ID <tlQKu-8g6-7@gated-at.bofh.it> (permalink)
References <tlPEK-7s9-5@gated-at.bofh.it> <tlPEK-7s9-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 2017/3/17 10:09, Jaegeuk Kim wrote:
> The atomic writes only supports regular files for database.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/file.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index da6d33d1bb34..d486e02b43c2 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1522,6 +1522,9 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
>  	if (f2fs_is_atomic_file(inode))
>  		goto out;
>  
> +	if (!S_ISREG(inode->i_mode))
> +		return -EINVAL;

goto out;

Thanks,

> +
>  	ret = f2fs_convert_inline_inode(inode);
>  	if (ret)
>  		goto out;
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] f2fs: don't allow atomic writes for not regular files Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-17 03:20 +0100
  Re: [f2fs-dev] [PATCH 2/2] f2fs: don't allow atomic writes for not  regular files Chao Yu <yuchao0@huawei.com> - 2017-03-17 04:30 +0100
    Re: [f2fs-dev] [PATCH 2/2] f2fs: don't allow atomic writes for not  regular files Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-17 14:10 +0100

csiph-web