Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1602868
| From | Eric Dumazet <eric.dumazet@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path |
| Date | 2017-03-16 23:10 +0100 |
| Message-ID | <tlLKO-4LF-9@gated-at.bofh.it> (permalink) |
| References | <tlItA-2iT-5@gated-at.bofh.it> <tlItB-2iT-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 2017-03-16 at 11:32 -0700, Alexander Duyck wrote:
> From: Sridhar Samudrala <sridhar.samudrala@intel.com>
>
> Call sk_mark_napi_id() in the ACK receive path of a TCP_NEW_SYN_RECV
> socket, so that sk->napi_id is set even if the socket hasn't yet received
> any data. With this change we should be able to start busy polling
> slightly earlier.
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
> net/ipv4/tcp_ipv4.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 08d870e45658..b86002a296f1 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -1687,6 +1687,7 @@ int tcp_v4_rcv(struct sk_buff *skb)
> tcp_v4_send_reset(nsk, skb);
> goto discard_and_relse;
> } else {
> + sk_mark_napi_id(nsk, skb);
> sock_put(sk);
> return 0;
> }
>
Seems good, but what about IPv6 ?
Frankly this calls for the sk_mark_napi_id() being done in
tcp_child_process() instead of its four callers.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[net-next PATCH 0/5] Add busy poll support for epoll under certain circumstances Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-16 19:40 +0100
[net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-16 19:40 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-16 23:10 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-16 23:50 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-17 00:00 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-17 03:50 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-17 04:00 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-17 04:00 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-17 04:10 +0100
Re: [net-next PATCH 1/5] net: Do not record sender_cpu as napi_id in socket receive paths "Samudrala, Sridhar" <sridhar.samudrala@intel.com> - 2017-03-16 23:50 +0100
[net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-16 19:40 +0100
Re: [net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-16 23:10 +0100
Re: [net-next PATCH 2/5] net: Call sk_mark_napi_id() in the ACK receive path Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-16 23:40 +0100
[net-next PATCH 3/5] net: Introduce SO_INCOMING_NAPI_ID Alexander Duyck <alexander.duyck@gmail.com> - 2017-03-16 19:40 +0100
Re: [net-next PATCH 3/5] net: Introduce SO_INCOMING_NAPI_ID Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-17 00:00 +0100
Re: [net-next PATCH 0/5] Add busy poll support for epoll under certain circumstances Michael Kerrisk <mtk.manpages@gmail.com> - 2017-03-18 12:50 +0100
csiph-web