Re: 'perf test tsc' failing, bisected to "sched/clock: Provide better clock continuity"

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: 'perf test tsc' failing, bisected to "sched/clock: Provide better clock continuity"
Date	2017-03-16 20:30 +0100
Message-ID	<tlJfX-2Un-5@gated-at.bofh.it> (permalink)
References	<tlEgi-7RT-31@gated-at.bofh.it> <tlF2I-8g9-53@gated-at.bofh.it> <tlIae-2ba-21@gated-at.bofh.it> <tlItB-2iT-43@gated-at.bofh.it> <tlJfY-2Un-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Thu, Mar 16, 2017 at 04:21:38PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Mar 16, 2017 at 03:36:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Mar 16, 2017 at 07:11:21PM +0100, Peter Zijlstra escreveu:
> > > On Thu, Mar 16, 2017 at 03:53:11PM +0100, Peter Zijlstra wrote:
> > > > On Thu, Mar 16, 2017 at 11:01:03AM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > [root@jouet ~]# perf test -v tsc
> > > > > 55: Convert perf time to TSC                   :
> > > > > Convert perf time to TSC: FAILED!
> > > > >     sched/clock: Provide better clock continuity
> > 
> > > > Right, ahunter also complained about this. I had a half arsed fugly
> > > > patch in the works. Let me see if I can improve and finish.
> >  
> > > The below seems to cure things for me...
> > 
> > Building...
> 
> Didn't apply to perf/urgent:
> 
> [acme@jouet linux]$ patch -p1 < /wb/1.patch 
> patching file arch/x86/events/core.c
> Hunk #1 succeeded at 2243 (offset -1 lines).
> Hunk #2 succeeded at 2251 (offset -1 lines).
> Hunk #3 succeeded at 2265 (offset -1 lines).
> Hunk #4 succeeded at 2273 (offset -1 lines).
> patching file arch/x86/include/asm/timer.h
> patching file arch/x86/kernel/tsc.c
> Hunk #1 FAILED at 328.

perf/core almost super clean:

[acme@felicio linux]$ patch -p1 < /wb/1.patch 
patching file arch/x86/events/core.c
patching file arch/x86/include/asm/timer.h
patching file arch/x86/kernel/tsc.c
patching file include/linux/sched/clock.h
patching file kernel/sched/clock.c
Hunk #3 succeeded at 154 with fuzz 2 (offset -7 lines).
Hunk #4 succeeded at 231 (offset -7 lines).
Hunk #5 succeeded at 317 (offset -7 lines).
[acme@felicio linux]$

Building...

Thread

'perf test tsc' failing, bisected to "sched/clock: Provide better  clock continuity" Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-16 15:10 +0100
  Re: 'perf test tsc' failing, bisected to "sched/clock: Provide  better clock continuity" Peter Zijlstra <peterz@infradead.org> - 2017-03-16 16:00 +0100
    Re: 'perf test tsc' failing, bisected to "sched/clock: Provide  better clock continuity" Peter Zijlstra <peterz@infradead.org> - 2017-03-16 19:20 +0100
      Re: 'perf test tsc' failing, bisected to "sched/clock: Provide  better clock continuity" Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-16 19:40 +0100
        Re: 'perf test tsc' failing, bisected to "sched/clock: Provide  better clock continuity" Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-16 20:30 +0100
          Re: 'perf test tsc' failing, bisected to "sched/clock: Provide  better clock continuity" Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-20 14:30 +0100
        Re: 'perf test tsc' failing, bisected to "sched/clock: Provide  better clock continuity" Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-16 20:40 +0100

csiph-web