Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602800

Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller
Date 2017-03-16 20:30 +0100
Message-ID <tlJfX-2Un-3@gated-at.bofh.it> (permalink)
References <tlHnP-1ze-5@gated-at.bofh.it> <tlHnQ-1ze-15@gated-at.bofh.it> <tlHHc-1ID-17@gated-at.bofh.it> <tlI0y-25v-33@gated-at.bofh.it> <tlIjV-2f6-53@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, 16 Mar 2017 11:19:44 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Thu, Mar 16, 2017 at 11:09 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > +
> > +       /* Since we don't care about cs, move flags there to simplify return */
> > +       movl    14*4(%esp), %eax
> > +       movl    %eax, 13*4(%esp)
> > +
> > +       /* Move return ip back to its original location */
> > +       movl    12*4(%esp), %eax
> > +       movl    %eax, 14*4(%esp)  
> 
> Could this perhaps be removed entirely?
> 
> The return code could instead do:
> 
>         ... restore all the normal registers ..
> 
>         # Now restore flags that is under the return address and our
> fake __KERNEL_CS
>         pushl 8(%esp)
>         popfl
> 
>         # and then return, skipping __KERNEL_CS and %flasg
>         ret $8
> 
> which is smaller and simpler than (again) playing games with stack entries.
> 
>                 Linus


The thing is we don't return, we jump to the location that may be
modified to run the function graph tracer.

.Lftrace_ret:
#ifdef CONFIG_FUNCTION_GRAPH_TRACER
.globl ftrace_graph_call
ftrace_graph_call:
	jmp	ftrace_stub  <- this can turn to a jump to function graph tracing
#endif

WEAK(ftrace_stub)
	ret
END(ftrace_caller)


[...]

	popf					/* flags is in the cs location */
	jmp	.Lftrace_ret


-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/5 v2] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 18:30 +0100
  Re: [PATCH 4/5 v2] ftrace/x86_32: Clean up ftrace_regs_caller Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 18:50 +0100
    Re: [PATCH 4/5 v2] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 19:00 +0100
    [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 19:10 +0100
      Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 19:30 +0100
        Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 20:30 +0100
          Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 20:50 +0100
        Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 20:30 +0100
          Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 20:40 +0100
            Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 21:00 +0100
        Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 20:30 +0100
        [PATCH 4/5 v3.1] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 21:20 +0100

csiph-web