Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1602763

Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table
Date 2017-03-16 19:40 +0100
Message-ID <tlItB-2iT-29@gated-at.bofh.it> (permalink)
References <tjsVX-4FY-13@gated-at.bofh.it> <tjsVX-4FY-11@gated-at.bofh.it> <tjxsB-7NS-11@gated-at.bofh.it> <tlIjU-2f6-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Dmitry,

On 03/16/2017 03:25 PM, Dmitry Torokhov wrote:
> On Fri, Mar 10, 2017 at 10:22 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>>
>> On Fri, Mar 10, 2017 at 10:33:06AM -0300, Javier Martinez Canillas wrote:
>>> The OF device ID table doesn't have a sentinel NULL entry and so it
>>> causes the following error:
>>>
>>> FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry!
>>> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
>>> make[1]: *** [__modpost] Error 1
>>> Makefile:1493: recipe for target 'modules' failed
>>> make: *** [modules] Error 2
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>
>> This was also causing issues with 0-day builder when driver is built
>> into the kernel.
> 
> It looks like Greg KH picked my version of this patch...
>

Great, glad that your version was picked since it seems these two patches
were never going to make it.
 
> Thanks.
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel  entry to OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-16 19:30 +0100
  Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel  entry to OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 19:40 +0100
    Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel  entry to OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-16 19:50 +0100
      Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel  entry to OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-16 19:50 +0100

csiph-web