Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

From	Dan Streetman <ddstreet@ieee.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support
Date	2017-03-16 19:30 +0100
Message-ID	<tlIjU-2f6-31@gated-at.bofh.it> (permalink)
References	(1 earlier) <tewxc-6Qy-19@gated-at.bofh.it> <tewxc-6Qy-15@gated-at.bofh.it> <tfuWl-6ZE-9@gated-at.bofh.it> <tiNJ8-1kt-17@gated-at.bofh.it> <tlGBt-10m-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 16, 2017 at 12:33 PM, Herbert Xu
<herbert@gondor.apana.org.au> wrote:
> On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote:
>>
>>
>> setting the ASYNC bit makes it synchronous?  that seems backwards...?
>
> You set the ASYNC bit in the mask and leave it clear in the type.
> That way only algorithms with the ASYNC bit off will match.

aha, ok i get it now.

>> zswap gets the fun of being the first crypto compression consumer to
>> switch to the new api? ;-)
>
> BTW I think we should hold off on converting zswap for now.

ok that sounds good, we can wait.  Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework  support Herbert Xu <herbert@gondor.apana.org.au> - 2017-03-16 17:40 +0100
  Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support Dan Streetman <ddstreet@ieee.org> - 2017-03-16 19:30 +0100

csiph-web