Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602776

Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args'

From Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args'
Date 2017-03-16 20:00 +0100
Message-ID <tlIMV-2t1-1@gated-at.bofh.it> (permalink)
References (5 earlier) <tiOYy-25e-9@gated-at.bofh.it> <tiRtn-3QL-11@gated-at.bofh.it> <tlFYJ-td-3@gated-at.bofh.it> <tlHxv-1ET-17@gated-at.bofh.it> <tlItB-2iT-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 16, 2017 at 01:36:35PM -0500, Josh Poimboeuf wrote:
> On Thu, Mar 16, 2017 at 01:32:01PM -0400, Steven Rostedt wrote:
> > On Thu, 16 Mar 2017 10:42:08 -0500
> > Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > > +	ACCUMULATE_OUTGOING_ARGS := 1
> > > +    endif
> > > +  endif
> > > +endif
> > > +
> > > +# Jump labels need '-maccumulate-outgoing-args' for gcc < 4.5.2 to prevent
> > 
> > Can we make a test instead? I hate testing versions, and things get
> > backported all the time. We usually like to have a test case instead of
> > relying on versions. Not to mention, a newer gcc may one day break.
> 
> Tests are generally better, but I'm not sure how to test for this
> cleanly.  The test is rather big for embedding in a makefile:
> 
>   https://gcc.gnu.org/bugzilla/attachment.cgi?id=22199
> 
> Any ideas?

After some snooping I discovered there's some precedent for doing this
in the scripts/gcc-*.sh files.  So maybe I'll add a test there and call
it from the Makefile.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86: mostly disable '-maccumulate-outgoing-args' Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-16 17:00 +0100
  Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args' Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 18:40 +0100
    Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args' Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-16 19:40 +0100
      Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args' Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-16 20:00 +0100
        Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args' Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 20:10 +0100
        Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args' Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-16 20:20 +0100
      Re: [PATCH] x86: mostly disable '-maccumulate-outgoing-args' Steven Rostedt <rostedt@goodmis.org> - 2017-03-16 20:10 +0100
  [PATCH v2] x86: mostly disable '-maccumulate-outgoing-args' Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-16 20:40 +0100
    Re: [PATCH v2] x86: mostly disable '-maccumulate-outgoing-args' Ingo Molnar <mingo@kernel.org> - 2017-03-22 09:00 +0100
      Re: [PATCH v2] x86: mostly disable '-maccumulate-outgoing-args' Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-22 17:00 +0100

csiph-web