Re: [RFC PATCH] rework memory hotplug onlining

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] rework memory hotplug onlining
Date	2017-03-16 18:50 +0100
Message-ID	<tlHHc-1ID-3@gated-at.bofh.it> (permalink)
References	<tldg5-5yN-7@gated-at.bofh.it> <tlqdk-6eS-21@gated-at.bofh.it> <tlzqi-4aX-15@gated-at.bofh.it> <tlHxv-1ET-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 16-03-17 17:19:34, Kani, Toshimitsu wrote:
> On Thu, 2017-03-16 at 09:54 +0100, Michal Hocko wrote:
> > On Wed 15-03-17 23:08:14, Kani, Toshimitsu wrote:
> > > On Wed, 2017-03-15 at 10:13 +0100, Michal Hocko wrote:
>  :
> > > > -	zone = page_zone(pfn_to_page(valid_start));
> > > 
> > > Please do not remove the fix made in a96dfddbcc043. zone needs to
> > > be set from valid_start, not from start_pfn.
> > 
> > Thanks for pointing this out. I was scratching my head about this
> > part but was too tired from previous git archeology so I didn't check
> > the history of this particular part.
> >
> > I will restore the original behavior but before I do that I am really
> > curious whether partial memblocks are even supported for onlining.
> > Maybe I am missing something but I do not see any explicit checks for
> > NULL struct page when we set zone boundaries or online a memblock. Is
> > it possible those memblocks are just never hotplugable?
> 
> check_hotplug_memory_range() checks if a given range is aligned by the
> section size.

Ohh, right you are! I have completely missed check_hotplug_memory_range.
Thanks for pointing it out.

-- 
Michal Hocko
SUSE Labs

Thread

[RFC PATCH] rework memory hotplug onlining Michal Hocko <mhocko@kernel.org> - 2017-03-15 10:20 +0100
  Re: [RFC PATCH] rework memory hotplug onlining Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-03-15 11:50 +0100
    ZONE_NORMAL vs. ZONE_MOVABLE (was: Re: [RFC PATCH] rework memory  hotplug onlining) Michal Hocko <mhocko@kernel.org> - 2017-03-15 13:40 +0100
      Re: ZONE_NORMAL vs. ZONE_MOVABLE Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-03-15 14:00 +0100
        Re: ZONE_NORMAL vs. ZONE_MOVABLE Michal Hocko <mhocko@kernel.org> - 2017-03-15 14:20 +0100
          Re: ZONE_NORMAL vs. ZONE_MOVABLE Andrea Arcangeli <aarcange@redhat.com> - 2017-03-15 17:40 +0100
            Re: ZONE_NORMAL vs. ZONE_MOVABLE Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2017-03-16 06:40 +0100
              Re: ZONE_NORMAL vs. ZONE_MOVABLE Andrea Arcangeli <aarcange@redhat.com> - 2017-03-16 20:20 +0100
                Re: ZONE_NORMAL vs. ZONE_MOVABLE Igor Mammedov <imammedo@redhat.com> - 2017-03-17 11:30 +0100
                Re: ZONE_NORMAL vs. ZONE_MOVABLE Joonsoo Kim <js1304@gmail.com> - 2017-03-20 07:40 +0100
  Re: [RFC PATCH] rework memory hotplug onlining "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-03-16 00:10 +0100
    Re: [RFC PATCH] rework memory hotplug onlining Michal Hocko <mhocko@kernel.org> - 2017-03-16 10:00 +0100
      Re: [RFC PATCH] rework memory hotplug onlining "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-03-16 18:40 +0100
        Re: [RFC PATCH] rework memory hotplug onlining Michal Hocko <mhocko@kernel.org> - 2017-03-16 18:50 +0100
  Re: [RFC PATCH] rework memory hotplug onlining Michal Hocko <mhocko@kernel.org> - 2017-03-17 14:40 +0100
    Re: [RFC PATCH] rework memory hotplug onlining Dan Williams <dan.j.williams@gmail.com> - 2017-03-21 15:20 +0100

csiph-web