Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1602225
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages |
| Date | 2017-03-16 13:30 +0100 |
| Message-ID | <tlCHw-6I6-23@gated-at.bofh.it> (permalink) |
| References | <tgD1v-5Gf-9@gated-at.bofh.it> <tjqAO-38Z-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/03/2017 16:15, Brijesh Singh wrote:
>
> __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address,
> - struct page *base)
> + pte_t *pbase, unsigned long new_pfn)
> {
> - pte_t *pbase = (pte_t *)page_address(base);
Just one comment and I'll reply to Boris, I think you can compute pbase
with pfn_to_kaddr, and avoid adding a new argument.
> */
> - __set_pmd_pte(kpte, address, mk_pte(base, __pgprot(_KERNPG_TABLE)));
> + __set_pmd_pte(kpte, address,
> + native_make_pte((new_pfn << PAGE_SHIFT) + _KERNPG_TABLE));
And this probably is better written as:
__set_pmd_pte(kpte, address, pfn_pte(new_pfn, __pgprot(_KERNPG_TABLE));
Paolo
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages Paolo Bonzini <pbonzini@redhat.com> - 2017-03-16 13:30 +0100
csiph-web