Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis
Date	2017-03-16 11:30 +0100
Message-ID	<tlAPo-5jO-11@gated-at.bofh.it> (permalink)
References	<tlt1v-8aE-3@gated-at.bofh.it> <tlt1w-8aE-25@gated-at.bofh.it> <tlyDV-3Np-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-03-16 at 09:02 +0100, Michal Hocko wrote:
> On Wed 15-03-17 18:59:59, Joe Perches wrote:
> > whitespace changes only - git diff -w shows no difference
> 
> what is the point of this whitespace noise? Does it help readability?

Yes.  Consistency helps.

> To be honest I do not think so.

Opinions always vary.

>  Such a patch would make sense only if it
> was a part of a larger series where other patches would actually do
> something useful.

Do please read the 0/n introduction to this series.

And do remember to always strip the useless stuff you
unnecessarily quoted too.  66kb in this case.

There was a separate patch series 0/3 that actually did
the more useful stuff.

This patch series was purposely separated.

Thread

[PATCH 00/15] mm: page_alloc: style neatenings Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
  [PATCH 03/15] mm: page_alloc: fix brace positions Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
  [PATCH 05/15] mm: page_alloc: Move __meminitdata and __initdata uses Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
  [PATCH 01/15] mm: page_alloc: whitespace neatening Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
  [PATCH 13/15] mm: page_alloc: Remove unnecessary parentheses Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
  [PATCH 15/15] mm: page_alloc: Move logical continuations to EOL Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
  [PATCH 12/15] mm: page_alloc: Avoid pointer comparisons to NULL Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
  [PATCH 10/15] mm: page_alloc: 80 column neatening Joe Perches <joe@perches.com> - 2017-03-16 03:10 +0100
    Re: [PATCH 10/15] mm: page_alloc: 80 column neatening Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-16 10:00 +0100
  Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis Joe Perches <joe@perches.com> - 2017-03-16 11:30 +0100
    Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis Michal Hocko <mhocko@kernel.org> - 2017-03-16 11:40 +0100

csiph-web