[PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andi Kleen <andi@firstfloor.org>
Newsgroups	linux.kernel
Subject	[PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd
Date	Wed, 15 Mar 2017 03:20:01 +0100
Message-ID	<tl6HD-OK-1@gated-at.bofh.it> (permalink)
References	<tl6HD-OK-3@gated-at.bofh.it>
X-Original-To	akpm@linux-foundation.org
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.36,166,1486454400"; d="scan'208";a="75497459"
X-Mailer	git-send-email 2.9.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>, megaraidlinux.pdl@broadcom.com
X-Original-Date	Tue, 14 Mar 2017 19:14:30 -0700
X-Original-Message-ID	<20170315021431.13107-7-andi@firstfloor.org>
X-Original-References	<20170315021431.13107-1-andi@firstfloor.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1600988

Show key headers only | View raw

From: Andi Kleen <ak@linux.intel.com>

Remove an inline from a fairly big function that is used often.
It's unlikely that calling or not calling it makes a lot of difference.

Saves around 8k text in my kernel.

   text    data     bss     dec     hex filename
9047801 5367568 11116544        25531913        1859609 vmlinux-before-megasas
9039417 5367568 11116544        25523529        1857549 vmlinux-megasas

Cc: megaraidlinux.pdl@broadcom.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 7ac9a9ee9bd4..55b71de3fb1f 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -244,7 +244,7 @@ struct megasas_cmd *megasas_get_cmd(struct megasas_instance
  * @instance:		Adapter soft state
  * @cmd:		Command packet to be returned to free command pool
  */
-inline void
+void
 megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd)
 {
 	unsigned long flags;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd Andi Kleen <andi@firstfloor.org> - 2017-03-15 03:20 +0100
  RE: [PATCH 6/7] megasas: Remove expensive inline from megasas_return_cmd Sumit Saxena <sumit.saxena@broadcom.com> - 2017-03-15 13:20 +0100

csiph-web