Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599446

Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM family version

Show all headers | View raw

On Mon, Mar 13, 2017 at 12:54:24PM +0000, Li, Meng wrote:
> 
> 
> > -----Original Message-----
> > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com]
> > Sent: Monday, March 13, 2017 7:54 PM
> > To: Li, Meng
> > Cc: linux-kernel@vger.kernel.org; peterhuewe@gmx.de;
> > tpmdd@selhorst.net; jgunthorpe@obsidianresearch.com; tpmdd-
> > devel@lists.sourceforge.net
> > Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM family version
> > 
> > On Mon, Mar 13, 2017 at 05:20:17PM +0800, Meng.Li@windriver.com wrote:
> > > From: Limeng <Meng.Li@windriver.com>
> > >
> > > So far, there is not a sysfs interface for user space code to check
> > > the TPM family version(TPM1.x or TPM2). So, add a file named
> > > description in /sys/class/tpm/tpmX/ to show it.
> > >
> > > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > > ---
> > 
> > Is this the first or which version of the patch is this? Version number and
> > changelog are missing :/
> 
> Hi Jarkko,
> 
> This is the second version of this patch. The first one is reviewed by Peter who give out some good advices.
> 
> It is my first time to submit patch to upstream(main line),

A tip for you then. Wait at least one day between patch versions. That
gives people time to comment on your patches, and you can fix many
different issues at once.

> and I am not very clear with the submitting rule.

A good start is:

Documentation/process/submitting-patches.rst

> So, could you please give me a template to record the version and changing log?

After the --- write one line per change you made from the previous
version. Also, v3 should also contain the v2 change history etc...

Picking a random example from the web:

http://patchwork.ozlabs.org/patch/710615/

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: Add sysfs interface to show TPM family version <Meng.Li@windriver.com> - 2017-03-13 10:30 +0100
  Re: [PATCH] tpm: Add sysfs interface to show TPM family version Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-13 13:00 +0100
    RE: [PATCH] tpm: Add sysfs interface to show TPM family version "Li, Meng" <Meng.Li@windriver.com> - 2017-03-13 14:00 +0100
      Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM  family version Andrew Lunn <andrew@lunn.ch> - 2017-03-13 15:40 +0100
      Re: [PATCH] tpm: Add sysfs interface to show TPM family version Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-13 16:10 +0100
        Re: [PATCH] tpm: Add sysfs interface to show TPM family version Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-03-13 18:00 +0100
          Re: [PATCH] tpm: Add sysfs interface to show TPM family version Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-13 19:40 +0100
  Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM  family version James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-03-13 19:50 +0100

csiph-web