Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599450
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work |
| Date | 2017-03-13 15:40 +0100 |
| Message-ID | <tkziG-1PZ-11@gated-at.bofh.it> (permalink) |
| References | <tkshb-5nd-5@gated-at.bofh.it> <tkshc-5nd-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Monday 13 March 2017 16:04:10 Masaki Ota wrote:
> From: Masaki Ota <masaki.ota@jp.alps.com>
> - V8 Button pad Stick Right and Middle button don't work.
> - Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process.
>
> Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> drivers/input/mouse/alps.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index a70c860..a13404f 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -1287,10 +1287,8 @@ static int alps_decode_ss4_v2(struct alps_fields *f,
> /* handle buttons */
> if (pkt_id == SS4_PACKET_ID_STICK) {
> f->ts_left = !!(SS4_BTN_V2(p) & 0x01);
> - if (!(priv->flags & ALPS_BUTTONPAD)) {
> - f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
> - f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
> - }
> + f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
> + f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
> } else {
> f->left = !!(SS4_BTN_V2(p) & 0x01);
> if (!(priv->flags & ALPS_BUTTONPAD)) {
--
Pali Rohár
pali.rohar@gmail.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] Fix V8 device information issue Masaki Ota <012nexus@gmail.com> - 2017-03-13 08:10 +0100
[PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work Masaki Ota <012nexus@gmail.com> - 2017-03-13 08:10 +0100
Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work Pali Rohár <pali.rohar@gmail.com> - 2017-03-13 15:40 +0100
Re: [PATCH 1/2] Fix V8 device information issue Pali Rohár <pali.rohar@gmail.com> - 2017-03-13 15:40 +0100
csiph-web