Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599291

Re: [PATCH 1/2] [RFC] base: soc: Let soc_device_match() return no match when called too early

Show all headers | View raw

On Thu, Mar 9, 2017 at 7:18 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> If soc_device_match() is called before the SoC bus has been registered,
> bus_for_each_dev() returns -EINVAL, which is considered a match, as it
> is non-zero.
>
> While calling soc_device_match() can be considered an integration
> mistake, returning a match is counter-intuitive: soc_device_match() is
> typically used to handle quirks, i.e. to deviate from the default path.
> Hence add a check to abort checking and return no match instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Acked-by: Arnd Bergmann <arnd@arndb.de>

> Should this use WARN_ONCE()?

I wouldn't mind that either, but your current version seems sufficient.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] [RFC] base: soc: Let soc_device_match() return no match when called too early Geert Uytterhoeven <geert+renesas@glider.be> - 2017-03-09 19:20 +0100
  Re: [PATCH 1/2] [RFC] base: soc: Let soc_device_match() return no  match when called too early Arnd Bergmann <arnd@arndb.de> - 2017-03-13 13:40 +0100

csiph-web