Re: [i2c-tools PATCH v2] i2ctransfer: add new tool

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [i2c-tools PATCH v2] i2ctransfer: add new tool
Date	2017-03-13 13:30 +0100
Message-ID	<tkxgS-qV-11@gated-at.bofh.it> (permalink)
References	<ti1XQ-146-31@gated-at.bofh.it> <ti7qx-53n-7@gated-at.bofh.it> <tkw1s-852-23@gated-at.bofh.it> <tkwXw-jQ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> > > > +.RI [ data ]
> > > > +.RI [ desc
> > > > +.RI [ data ]]
> > > 
> > > You could join the previous two lines.
> > 
> > Try it. You will miss some spaces, then.
> 
> It works fine with quoting:
> 
> 	.RI [ "desc " [ data "]] ..."
> 
> . But ok, it's at least arguable if this is better than your solution.

I prefer my solution ;)

> > I wonder: will another I2C master start a transfer on a repeated start?
> > Need to investigate.
> 
> I'd say it must not. It should have logic to detect bus busy and delay
> any transfers until the bus becomes idle. With a repeated start the bus
> doesn't become idle between two transfers.

I totally agree. However, I think I'll try to stress-test a little when
I use my scope next time. Just to have some real world experiences...

> ah, ok. BTW, I like tools that clean up after themselves. This way
> debugging is much easier if you look for lost memory. And yes, this
> doesn't matter much for short-living programs like i2c-tools, but I like
> being consistent here and also do the cleanup for this this type of
> program.

I see this point. And I see that the program became quite more complex
which makes future modifications more error prone. Your exit path
consolidation suggestion was a good example for that. But anayway, the
cleanup is there now, hope you'll all be happy :)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[i2c-tools PATCH v2] i2ctransfer: add new tool Wolfram Sang <wsa@the-dreams.de> - 2017-03-06 15:40 +0100
  Re: [i2c-tools PATCH v2] i2ctransfer: add new tool Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-06 16:40 +0100
    Re: [i2c-tools PATCH v2] i2ctransfer: add new tool Wolfram Sang <wsa@the-dreams.de> - 2017-03-06 20:20 +0100
  Re: [i2c-tools PATCH v2] i2ctransfer: add new tool Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-03-06 21:30 +0100
    Re: [i2c-tools PATCH v2] i2ctransfer: add new tool Wolfram Sang <wsa@the-dreams.de> - 2017-03-13 12:10 +0100
      Re: [i2c-tools PATCH v2] i2ctransfer: add new tool Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-03-13 13:10 +0100
        Re: [i2c-tools PATCH v2] i2ctransfer: add new tool Wolfram Sang <wsa@the-dreams.de> - 2017-03-13 13:30 +0100

csiph-web