Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599270
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h |
| Date | 2017-03-13 13:20 +0100 |
| Message-ID | <tkx7c-nh-13@gated-at.bofh.it> (permalink) |
| References | <tjP69-3gI-15@gated-at.bofh.it> <tkbT4-294-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote: > On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote: > > This patch resolves the "Comparisons should place the constant on > > the right side of the test" found with checkpatch tool. > > Both are constants, I think checkpatch is the thing that is wrong here, > don't you agree? Sort of constant-ish... The sizeof(*value) changes each time the macro is used. I feel like checkpatch is right. regads, dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: lustre fix constant comparision style issue in lu_object.h Craig Inches <Craig@craiginches.com> - 2017-03-11 14:20 +0100
Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 14:40 +0100
Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 13:20 +0100
Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h Craig Inches <craig@craiginches.com> - 2017-03-13 14:20 +0100
csiph-web