Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599147

RE: Bad DT binding (hisi-pcie-almost-ecam)

Show all headers | View raw

Hi Geert

[...]

> >          {
> > -           .compatible = "hisilicon,pcie-almost-ecam",
> > +         .compatible = "hisilicon,pcie-almost-ecam-hip06",
> 
> Shouldn't that be "hisilicon,hip06-pcie-almost-ecam"?
> 
> > +         .data           = (void *) &hisi_pcie_platform_ops,
> > + },
> > + {
> > +         .compatible = "hisilicon,pcie-almost-ecam-hip07",
> 
> Shouldn't that be "hisilicon,hip07-pcie-almost-ecam"?

Indeed prefixing the SoC name is more consistent and it looks better

Many thanks
Gab

> 
> >                  .data       = (void *) &hisi_pcie_platform_ops,
> >          },
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a
> hacker. But
> when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bad DT binding (hisi-pcie-almost-ecam) Mark Rutland <mark.rutland@arm.com> - 2017-03-10 18:50 +0100
  RE: Bad DT binding (hisi-pcie-almost-ecam) Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-03-13 09:20 +0100
    Re: Bad DT binding (hisi-pcie-almost-ecam) Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-13 10:00 +0100
      RE: Bad DT binding (hisi-pcie-almost-ecam) Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-03-13 10:40 +0100
    Re: Bad DT binding (hisi-pcie-almost-ecam) Mark Rutland <mark.rutland@arm.com> - 2017-03-13 11:50 +0100
      RE: Bad DT binding (hisi-pcie-almost-ecam) Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2017-03-13 14:20 +0100

csiph-web