Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599144

RE: [PATCH] phy: rcar-gen3-usb2: fix implementation for runtime PM

Show all headers | View raw

Hello!

> -----Original Message-----
> From: Sergei Shtylyov
> Sent: Monday, March 13, 2017 6:04 PM
> 
> Hello!
> 
> On 3/13/2017 9:24 AM, Yoshihiro Shimoda wrote:
> 
> > This patch fixes an issue that this driver doesn't take care of the runtime
> > PM. This code assumed that devm_phy_create() called pm_runtime_enable(dev),
> > but it misunderstood the dev_phy_create()'s specification.
> > This driver should call the own pm_runtime_pm() before dev_phy_create().
> 
>     Its own?

Yes. So, I will revise it.

> > Fixes: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> >  drivers/phy/phy-rcar-gen3-usb2.c | 29 +++++++++++++++++++++++------
> >  1 file changed, 23 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c
> > index afb4d04..23c4e86 100644
> > --- a/drivers/phy/phy-rcar-gen3-usb2.c
> > +++ b/drivers/phy/phy-rcar-gen3-usb2.c
> [...]
> > @@ -454,15 +462,22 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
> >  	provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> >  	if (IS_ERR(provider)) {
> >  		dev_err(dev, "Failed to register PHY provider\n");
> > +		ret = PTR_ERR(provider);
> > +		goto error;
> >  	} else if (channel->has_otg) {
> >  		int ret;
> >
> >  		ret = device_create_file(dev, &dev_attr_role);
> >  		if (ret < 0)
> > -			return ret;
> > +			goto error;
> >  	}
> >
> >  	return PTR_ERR_OR_ZERO(provider);
> 
>     Here 'provider' can no longer contain error -- *return* 0 seems to fit better.

Oops, I will fix it.

Best regards,
Yoshihiro Shimoda

> > +
> > +error:
> > +	pm_runtime_disable(dev);
> > +
> > +	return ret;
> >  }
> >
> >  static int rcar_gen3_phy_usb2_remove(struct platform_device *pdev)
> [...]
> 
> MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] phy: rcar-gen3-usb2: fix implementation for runtime PM Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-13 10:10 +0100
  RE: [PATCH] phy: rcar-gen3-usb2: fix implementation for runtime PM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2017-03-13 10:40 +0100

csiph-web