Re: [PATCH] mm: mark gup_pud_range as unused

From	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: mark gup_pud_range as unused
Date	2017-03-13 06:30 +0100
Message-ID	<tkqIq-46N-5@gated-at.bofh.it> (permalink)
References	<tkpjk-2RV-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 13, 2017 at 04:58:37PM +1300, Chris Packham wrote:
> The last caller to gup_pud_range was removed in commit c2febafc6773
> ("mm: convert generic code to 5-level paging"). Mark it as unused to
> silence a warning from gcc.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> I saw this warning when compiling 4.11-rc2 with -Werror. An equally valid fix
> would be to remove the function entirely but I went for the less invasive
> approach.

Thanks for report. But real fix is to call gup_pud_range() from
gup_p4d_range(), not itself.

I'll post a fix.
Reported-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reported-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: mark gup_pud_range as unused Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-03-13 05:00 +0100
  Re: [PATCH] mm: mark gup_pud_range as unused "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-13 06:30 +0100

csiph-web