[PATCH 07/14] cpufreq: intel_pstate: Skip unnecessary PID resets on init

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	[PATCH 07/14] cpufreq: intel_pstate: Skip unnecessary PID resets on init
Date	2017-03-12 18:40 +0100
Message-ID	<tkfDk-4GO-43@gated-at.bofh.it> (permalink)
References	<tkfDj-4GO-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

PID controller parameters only need to be initialized if the
get_target_pstate_use_performance() P-state selection routine
is going to be used.  It is not necessary to initialize them
otherwise, so don't do that.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/cpufreq/intel_pstate.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/cpufreq/intel_pstate.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/intel_pstate.c
+++ linux-pm/drivers/cpufreq/intel_pstate.c
@@ -1974,12 +1974,12 @@ static int intel_pstate_init_cpu(unsigne
 			intel_pstate_disable_ee(cpunum);
 
 		intel_pstate_hwp_enable(cpu);
+	} else if (pstate_funcs.get_target_pstate == get_target_pstate_use_performance) {
+		intel_pstate_pid_reset(cpu);
 	}
 
 	intel_pstate_get_cpu_pstates(cpu);
 
-	intel_pstate_pid_reset(cpu);
-
 	pr_debug("controlling: cpu %d\n", cpunum);
 
 	return 0;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 07/14] cpufreq: intel_pstate: Skip unnecessary PID resets on init "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-12 18:40 +0100

csiph-web