[PATCH v1] x86/platform/intel-mid: Correct MSI for watchdog device

Path	csiph.com!weretis.net!feeder6.news.weretis.net!feeder5.news.weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCH v1] x86/platform/intel-mid: Correct MSI for watchdog device
Date	Sun, 12 Mar 2017 16:10:02 +0100
Message-ID	<tkdia-3e0-7@gated-at.bofh.it> (permalink)
X-Original-To	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, linux-kernel@vger.kernel.org
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.36,152,1486454400"; d="scan'208";a="59293278"
X-Mailer	git-send-email 2.11.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, David Cohen <david.a.cohen@linux.intel.com>
X-Original-Date	Sun, 12 Mar 2017 17:07:44 +0200
X-Original-Message-ID	<20170312150744.45493-1-andriy.shevchenko@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1598655

Show key headers only | View raw

The interrupt line used for watchdog is 12 according to the official
Intel Edison BSP code.

And indeed after fixing it we start getting an interrupt and thus:
[  191.699951] Kernel panic - not syncing: Kernel Watchdog

Fixes: 78a3bb9e408b ("x86: intel-mid: add watchdog platform code for Merrifield")
Cc: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c b/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
index 86edd1e941eb..9e304e2ea4f5 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
@@ -19,7 +19,7 @@
 #include <asm/intel_scu_ipc.h>
 #include <asm/io_apic.h>
 
-#define TANGIER_EXT_TIMER0_MSI 15
+#define TANGIER_EXT_TIMER0_MSI 12
 
 static struct platform_device wdt_dev = {
 	.name = "intel_mid_wdt",
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] x86/platform/intel-mid: Correct MSI for watchdog device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-12 16:10 +0100
  [tip:x86/urgent] x86/platform/intel-mid: Correct MSI IRQ line for  watchdog device tip-bot for Andy Shevchenko <tipbot@zytor.com> - 2017-03-13 08:20 +0100

csiph-web