Re: [PATCH] ASoC: cs35l35: trivial fix to indentation

Path	csiph.com!goblin2!goblin.stu.neva.ru!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	walter harms <wharms@bfs.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: cs35l35: trivial fix to indentation
Date	Sun, 12 Mar 2017 16:00:02 +0100
Message-ID	<tkd8u-2UH-21@gated-at.bofh.it> (permalink)
References	<tjUSd-7fQ-5@gated-at.bofh.it>
X-Original-To	Colin King <colin.king@canonical.com>
Reply-To	wharms@bfs.de
User-Agent	Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	Brian Austin <brian.austin@cirrus.com>, Paul Handrigan <Paul.Handrigan@cirrus.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Jiri Kosina <trivial@kernel.org>, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 12 Mar 2017 15:55:28 +0100
X-Original-Message-ID	<58C56160.9070208@bfs.de>
X-Original-References	<20170311191922.6209-1-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1598653

Show key headers only | View raw


Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Remove extraneous tab to correct the nesting level indentation
> 
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  sound/soc/codecs/cs35l35.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>  
>  	for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
>  		cs35l35->supplies[i].supply = cs35l35_supplies[i];
> -		cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> +	cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>  


I have the feeling is better before the loop:

cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);

for (i = 0; i < cs35l35->num_supplies; i++)
     cs35l35->supplies[i].supply = cs35l35_supplies[i];

re,
 wh

>  	ret = devm_regulator_bulk_get(&i2c_client->dev,
>  			cs35l35->num_supplies,

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: cs35l35: trivial fix to indentation Colin King <colin.king@canonical.com> - 2017-03-11 20:30 +0100
  Re: [PATCH] ASoC: cs35l35: trivial fix to indentation walter harms <wharms@bfs.de> - 2017-03-12 16:00 +0100

csiph-web