[PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.roellig-ltd.de!open-news-network.org!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Daeseok Youn <daeseok.youn@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable
Date	Sun, 12 Mar 2017 15:50:01 +0100
Message-ID	<tkcYN-2Pm-9@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=0IdQFrR+jenMbBOiW+cE50FAFzMS9j8LzvlWEpfP/Z4=; b=rOTLDNTGpHv5F9sQblL2YEvQyGsmzvmVxgkyex+aLcoZPbgflBzjLWCeNCy6azs9hL zybgtXO470mdjQyNfxlG1hJvjY9D6ZrB+gC479CiaOs/rPB/RbWZuKpiJePU//0L2exU FzZl2zjmxrDYkpuFPJSdolXpgrcxyw3Ib/nFPNO8LSPakCy35uS4aczTlXjbjWq5n5mL d+bnfdJmEpk8omLXk4Je+10+MhNWxjwW1RvqRR6rJvfFYEzgQjGZZ5cFComms31WOkLi Y2D23+MZzXxNGTnqjzpK41anuYgS7CpM4YQx9qLUI1AmzeK1EP3jivqw99qfDfknCt4T /dWw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=0IdQFrR+jenMbBOiW+cE50FAFzMS9j8LzvlWEpfP/Z4=; b=qgbAl2KneUjzIfL+iG78DhyqOsEJGCU4YuxmOY/5l+26XiW5hiFmOvMZF3wq+RU7ZL y6P6wWuAGNs0l+WsAXzC4tc8BMLQ/yWxz4i3y11zXEwnPgnp8u7WlhBo1tH8S9HYTsVX 4rfk7kLG9LR9u20b3M6Du1wRzsUA1OQDuWo8/ony8bC2+IKOjqhDQbNwQERasv4jQGvf hBxZjg1PqBXghIzXgba2/DQUSc38Vy2Z2OynXZz6XZ+kqXmGH4z9zNEcWqTMmArbRfa5 AB+Ecwyi3QzQt0Af4cRUqiwOBvqM9UY357WW+5l9MHbXmiveNt6sgYUulHoZR6C35cyR dR2Q==
X-Gm-Message-State	AMke39k3KsmtTnSELfqUDSG+eeUg2Jt7Q2Czc5TsURvSzdFd0geKKgRoG9QbfnFb2Daf+A==
X-Received	by 10.99.37.199 with SMTP id l190mr31262680pgl.86.1489330069705; Sun, 12 Mar 2017 07:47:49 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
X-Original-Date	Sun, 12 Mar 2017 23:47:28 +0900
X-Original-Message-ID	<20170312144727.GA24031@jyoun-Latitude-E6530>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1598646

Show key headers only | View raw

The bd variable in dgnc_tty_digiseta() is assigned with
ch->ch_bd but it is not used in this function except checking NULL.
The ch->ch_bd could be replaced with bd variable in dgnc_tty_digiseta()

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/staging/dgnc/dgnc_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 7133d2c..b075350 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -2081,7 +2081,7 @@ static int dgnc_tty_digiseta(struct tty_struct *tty,
 	if (ch->ch_digi.digi_offlen > DIGI_PLEN)
 		ch->ch_digi.digi_offlen = DIGI_PLEN;
 
-	ch->ch_bd->bd_ops->param(tty);
+	bd->bd_ops->param(tty);
 
 	spin_unlock_irqrestore(&ch->ch_lock, flags);
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd  variable Daeseok Youn <daeseok.youn@gmail.com> - 2017-03-12 15:50 +0100
  Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd  variable Greg KH <gregkh@linuxfoundation.org> - 2017-03-13 23:30 +0100
    Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-14 02:50 +0100

csiph-web