Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property
Date	2017-03-12 13:10 +0100
Message-ID	<tkatX-1je-9@gated-at.bofh.it> (permalink)
References	<tenDA-eO-5@gated-at.bofh.it> <tenDA-eO-11@gated-at.bofh.it> <tgKFH-2n3-1@gated-at.bofh.it> <tgU2l-FV-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote:
> This reset is required in order to fully reset the internal state of the
> MIPI controller.
> 
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote:
> > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote:
> > > +	/*
> > > +	 * Note that the reset was not defined in the initial device tree, so
> > > +	 * we have to be prepared for it not being found.
> > > +	 */
> > > +	apb_rst = devm_reset_control_get(dev, "apb");  
> > 
> > Did this reset ever get documented in the device tree bindings? I
> > couldn't find it. Perhaps a follow-up patch is in order?
> 
> Here's a patch to do that.
> 
>  .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt  | 7 +++++++
>  1 file changed, 7 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 23/23] drm/rockchip: dw-mipi-dsi: add reset control Brian Norris <briannorris@chromium.org> - 2017-03-03 03:00 +0100
  [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property John Keeping <john@metanate.com> - 2017-03-03 13:00 +0100
    Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Brian Norris <briannorris@chromium.org> - 2017-03-03 21:50 +0100
    Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Sean Paul <seanpaul@chromium.org> - 2017-03-06 23:30 +0100
    Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Rob Herring <robh@kernel.org> - 2017-03-12 13:10 +0100

csiph-web