Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600728
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn |
| Date | 2017-03-14 18:20 +0100 |
| Message-ID | <tkYh5-3lW-33@gated-at.bofh.it> (permalink) |
| References | <tbKZH-176-3@gated-at.bofh.it> <tbKZI-176-17@gated-at.bofh.it> <tkVjb-1eJ-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote:
> On Thu, 16 Feb 2017, Joe Perches wrote:
> > To enable eventual removal of pr_warning
[]
> > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
[]
> > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata,
> > }
> > if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
> > if (!order)
> > - pr_warning("TWL4030: Bad order of scripts (sleep "\
> > - "script before wakeup) Leads to boot"\
> > - "failure on some boards\n");
> > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n");
>
> Is 80 chars considered the lessor sin?
Splitting logging messages into multiple lines is non preferred.
Documentation/process/coding-style.rst:
Breaking long lines and strings:
never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Lee Jones <lee.jones@linaro.org> - 2017-03-14 15:10 +0100
Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Joe Perches <joe@perches.com> - 2017-03-14 18:20 +0100
Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Lee Jones <lee.jones@linaro.org> - 2017-03-15 13:30 +0100
Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Joe Perches <joe@perches.com> - 2017-03-15 15:20 +0100
csiph-web