Re: [PATCH v2] mmc: meson-gx: remove mmc host on device removal

Path	csiph.com!news.freedyn.net!open-news-network.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mmc: meson-gx: remove mmc host on device removal
Date	Tue, 14 Mar 2017 17:30:02 +0100
Message-ID	<tkXuG-2Iv-33@gated-at.bofh.it> (permalink)
References	<tcgGd-4An-5@gated-at.bofh.it> <tcgGd-4An-7@gated-at.bofh.it>
X-Original-To	Michał Zegan <webczat@webczatnet.pl>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jCFzBbknxdwXYG2qoLN+0agGqmF64vcrsHaHfADicIw=; b=bc50RIewRQBWU7np5jEAnqC2cZkEd6dOVnFoVO4gpjRxi3ATvgL09Xi1ymzzEfJiom LEV58sVE+OdHHlQ/9/TRbaJP2d3XiJDW2r8nvMrxOctOUbk0Y+ApS7+nCffLaeqSHKSy tjhjICvz4YgQUpp58UaGLhdVvFJsFItdC9IEk=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jCFzBbknxdwXYG2qoLN+0agGqmF64vcrsHaHfADicIw=; b=k2TClCSoJtzUu4OEeqQ/+hPXutxlc8TuOl5LWNpDK63kIT5at5KjJ02XB6jvbxqPYC 3VBXwz0jmXQM55UevBapAcZqpU7XjgPeQY7J75I/ZtHgWM9dPBejxFMv5pYNPoHIzgIt GWxZTJzD2DmuXihg705EIxvnt7eMT8M87cNSnRBFc8HERgVtCTCC4PEianslJILn3f+E RlZAFpxIUlrpSSWhzPfmhv207fbeccDpb/RpmXrG/y64ScHw0Zdogkj4Qi5phzsjHmQ1 r/3jqMM+r6NY5dYliZfw96QT/KZnuG/J9zBRLCcWJiSibN+ZkzDU6pGvUreeuFuk9LgS G7CA==
X-Gm-Message-State	AMke39llfdN4ekUbZv5VGiX2E+YON/AHmiE0ujEsSKDdEBaFOllyW2QSBOfZCQ8+C71JNn8hWJtuApJlhIBgkCF3
X-Received	by 10.176.0.87 with SMTP id 81mr19152361uai.97.1489508492699; Tue, 14 Mar 2017 09:21:32 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	quoted-printable
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	Kevin Hilman <khilman@baylibre.com>, Carlo Caione <carlo@caione.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-amlogic@lists.infradead.org, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
X-Original-Date	Tue, 14 Mar 2017 17:21:32 +0100
X-Original-Message-ID	<CAPDyKFoi3ZeaM4CkR+B-zK59bD1i0U_QzzcnmsJE14mdee9ipA@mail.gmail.com>
X-Original-References	<20170218170647.5860-1-webczat@webczatnet.pl> <20170218170647.5860-2-webczat@webczatnet.pl>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1600668

Show key headers only | View raw

On 18 February 2017 at 18:06, Michał Zegan <webczat@webczatnet.pl> wrote:
> The mmc host was added in meson_mmc_probe, but never removed in
> meson_mmc_remove.
> Fix that by removing the host before deallocating other resources.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
> Tested-by: Michał Zegan <webczat@webczatnet.pl>

Thanks, applied for next!

Kind regards
Uffe

> ---
> changes since v1:
> rebased on top of patchset at
> https://patchwork.kernel.org/patch/9581057/
> This is in turn based on patchset at
> https://patchwork.kernel.org/patch/9561215/
>
>  drivers/mmc/host/meson-gx-mmc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e759e4c2e4a0..336b6a2e94c6 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
>  {
>         struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> +       mmc_remove_host(host->mmc);
> +
>         /* disable interrupts */
>         writel(0, host->regs + SD_EMMC_IRQ_EN);
>
> --
> 2.11.0
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] mmc: meson-gx: remove mmc host on device removal Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-14 17:30 +0100

csiph-web