Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600541

Re: [PATCH] fix pinctrl setup for i.IMX6

Show all headers | View raw

Hi Linus,

On Tue, Mar 14, 2017 at 03:47:58PM +0100, Linus Walleij wrote:
> On Tue, Feb 28, 2017 at 7:00 AM, Mika Penttilä
> <mika.penttila@nextfour.com> wrote:
> 
> > Recent pulls for mainline pre 4.11 introduced pinctrl setup changes and moved pinctrl-imx to
> > use generic helpers.
> >
> > Net effect was that hog group could not be resolved. I made it work for myself
> > with a two stage setup with create and start separated, and dt probe in between them.
> >
> >
> > Signed-off-by: Mika Penttilä <mika.penttila@nextfour.com>
> 
> Sorry for including the whole mail body, some people may have missed the
> mail. Notably the i.MX maintainers.
> 
> Your patch reminds me of the pinctrl_register() vs pinctrl_register_and_init()
> introduced by Tony Lindgren, can you look into this in commit
> 950b0d91dc108f54bccca5a2f75bb46f2df63d29
> "pinctrl: core: Fix regression caused by delayed work for hogs"?
> 
> Does switching pinctrl_register_and_init() back to pinctrl_register()
> solve your problem?
> 
> Gary: have you seen any problem like this?

Yes, Mika brought it up as soon as the first 4.11-rc appeared and indeed
this issue can be reproduced on any i.MX6 platform.

Then Tony offered a patch but you haven't replied to him yet:
https://lkml.org/lkml/2017/2/28/140

Regards,
Gary

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] fix pinctrl setup for i.IMX6 Linus Walleij <linus.walleij@linaro.org> - 2017-03-14 15:50 +0100
  Re: [PATCH] fix pinctrl setup for i.IMX6 Tony Lindgren <tony@atomide.com> - 2017-03-14 16:00 +0100
  Re: [PATCH] fix pinctrl setup for i.IMX6 Gary Bisson <gary.bisson@boundarydevices.com> - 2017-03-14 16:00 +0100
    Re: [PATCH] fix pinctrl setup for i.IMX6 Tony Lindgren <tony@atomide.com> - 2017-03-15 17:30 +0100
      Re: [PATCH] fix pinctrl setup for i.IMX6 Linus Walleij <linus.walleij@linaro.org> - 2017-03-16 12:30 +0100

csiph-web