Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600533

[PATCH 2/3] openrisc: fix issue handling 8 byte get_user calls

Show all headers | View raw

Was getting the following error with allmodconfig:

  ERROR: "__get_user_bad" [lib/test_user_copy.ko] undefined!

This was simply a missing break statement, causing an unwanted fall
through.

Signed-off-by: Stafford Horne <shorne@gmail.com>
---
 arch/openrisc/include/asm/uaccess.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/openrisc/include/asm/uaccess.h b/arch/openrisc/include/asm/uaccess.h
index 140faa1..1311e6b 100644
--- a/arch/openrisc/include/asm/uaccess.h
+++ b/arch/openrisc/include/asm/uaccess.h
@@ -211,7 +211,7 @@ do {									\
 	case 1: __get_user_asm(x, ptr, retval, "l.lbz"); break;		\
 	case 2: __get_user_asm(x, ptr, retval, "l.lhz"); break;		\
 	case 4: __get_user_asm(x, ptr, retval, "l.lwz"); break;		\
-	case 8: __get_user_asm2(x, ptr, retval);			\
+	case 8: __get_user_asm2(x, ptr, retval); break;			\
 	default: (x) = __get_user_bad();				\
 	}								\
 } while (0)
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Openrisc fixes for 4.11 Stafford Horne <shorne@gmail.com> - 2017-03-14 16:00 +0100
  [PATCH 2/3] openrisc: fix issue handling 8 byte get_user calls Stafford Horne <shorne@gmail.com> - 2017-03-14 16:00 +0100
  [PATCH 3/3] openrisc: Export symbols needed by modules Stafford Horne <shorne@gmail.com> - 2017-03-14 16:00 +0100
    Re: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-14 16:30 +0100
      Re: [OpenRISC] [PATCH 3/3] openrisc: Export symbols needed by modules Stafford Horne <shorne@gmail.com> - 2017-03-14 23:20 +0100
  [PATCH 1/3] openrisc: xchg: fix `computed is not used` warning Stafford Horne <shorne@gmail.com> - 2017-03-14 16:10 +0100

csiph-web