Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time
Date	2017-03-14 15:10 +0100
Message-ID	<tkVjb-1eJ-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <tkGNc-7uk-17@gated-at.bofh.it> <tkGWR-7zv-3@gated-at.bofh.it> <tkH6y-7El-5@gated-at.bofh.it> <tkSEF-7LJ-11@gated-at.bofh.it> <tkTr3-8mX-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> The never ever seeing R/W failure on MDIO bus is not exactly accurate.
>> We had with art (atheros calibration tool) the problem that interrupts
>> were being disabled which lead to MDIO operations running into
>> timout/failing.
>
> Yes, i've seen similar with power management bugs for the MDIO
> driver. But you get a cascade of failures, lots of warnings and error
> prints, it is clear something bad has happened, and the switch is in
> an inconsistent state. So having one more debug print which is also
> inconsistent does no really harm.
>
> Anyway, this whole conversation has taken more effort than just making
> this simple change to remove a few lines of code. So lets drop it and
> move on.

I don't understand nor agree with the fact that sometimes it's OK to not
check for errors, based on one developer assumptions. Not checking
return code is wrong and very likely error-prone.

If you really want to stand for that point, please send a patch series
which turns mv88e6xxx_read() and mv88e6xxx_write() into void functions.
I'd be glad to review and discuss this further. That would indeed make
*all* the driver code simpler.

Thanks,

        Vivien

Thread

[PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-13 20:30 +0100
  Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Andrew Lunn <andrew@lunn.ch> - 2017-03-13 23:40 +0100
    Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Florian Fainelli <f.fainelli@gmail.com> - 2017-03-13 23:50 +0100
      Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Andrew Lunn <andrew@lunn.ch> - 2017-03-14 00:00 +0100
        Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Matthias May <matthias.may@neratec.com> - 2017-03-14 12:20 +0100
          Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Andrew Lunn <andrew@lunn.ch> - 2017-03-14 13:10 +0100
            Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-14 15:10 +0100
              Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time Andrew Lunn <andrew@lunn.ch> - 2017-03-14 15:20 +0100

csiph-web