Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1600386

Re: [PATCH 1/3] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug

Path csiph.com!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Nicholas Piggin <npiggin@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug
Date Tue, 14 Mar 2017 14:40:02 +0100
Message-ID <tkUQa-Mo-35@gated-at.bofh.it> (permalink)
References <tkrl7-4G5-3@gated-at.bofh.it> <tkrl8-4G5-7@gated-at.bofh.it>
X-Original-To "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=jPmad4rE71u9wnXaSOHLfTBbpPWV9qv9z+/po8r1xDw=; b=Oyj5eC71rQm4C+fE37BLTZVQyID/JvyIjjqg5tUizMr2NmI9qb2e/H/czqzX+SBQRK I5gyl4UTyv9X/Soo9b3ofiPxc+ng8dM6NF4tDyaT5PCkVbCIvhx0HkHibjbes0TcLe1L RXoNhyhj22W8PpMw1MfxBNJ1SfEbGOQ+ClkZ07XFVud99ioVltjetnfSLjnP03bZpSX+ fUczhNoqLl4nhKABHix8Z10Kc4/bMeoEDM3tx6oA4/lExIA9AujhARHX8+caXzQRQQI6 sLYk9nnTIuHs0HuEY2kGZVLhoafQWtkymHhKGFJDCsfS8BV00JKU21oRBplMlt45ytyh cNlg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=jPmad4rE71u9wnXaSOHLfTBbpPWV9qv9z+/po8r1xDw=; b=mZYhDQwBMuDf1IBIM4jHMoCgp8QwYSYF8NCBvWwpX5L8JQAnv0/PmN8uFmqKYlpUjf zJP7Zjhh4AuOETSB8kZMfLS4L3REcBqEJRAIIRhofnv60fpQonOQR3JifLyOOosqxXom 8tJPwiTJgyGLdnkDFBqIR9MUcj8CrQtDt6BzMbR8M3bM1rXV2ZsXa7Ol4tNYeGARBBnM q0Qc4Wrxc5E7/HugA7TNJBy52nP49f+ul5MtiqXLSzTK++CrFHbVIRreLrF6S8ma2n1k TbLx9+abaXwkBrAA87ahQ6OfvpClNIk8anjmvdOG2G8l6/mg+DikH10iAomrmlACpOuS x/pA==
X-Gm-Message-State AMke39kUVAQTquMVYayuru7WwSuZQkHzT1hrL/DWTbMXXaj2YrDO2/T/w3J+GBetqHIeZg==
X-Received by 10.98.156.23 with SMTP id f23mr43457236pfe.3.1489498251626; Tue, 14 Mar 2017 06:30:51 -0700 (PDT)
Organization IBM
X-Mailer Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 34
X-Original-Cc Michael Ellerman <mpe@ellerman.id.au>, Michael Neuling <mikey@neuling.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, "Shreyas B. Prabhu" <shreyasbp@gmail.com>, Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>, Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>, Anton Blanchard <anton@samba.org>, Balbir Singh <bsingharora@gmail.com>, Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
X-Original-Date Tue, 14 Mar 2017 23:30:29 +1000
X-Original-Message-ID <20170314233029.478a7294@roar.ozlabs.ibm.com>
X-Original-References <cover.1489383815.git.ego@linux.vnet.ibm.com> <8c52750bfcd2a7c65673fc82763df7a7f335c79c.1489383815.git.ego@linux.vnet.ibm.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1600386

Show key headers only | View raw


On Mon, 13 Mar 2017 11:31:26 +0530
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com> wrote:

> [Changelog written with inputs from svaidy@linux.vnet.ibm.com]
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

> ---
>  arch/powerpc/platforms/powernv/smp.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/smp.c b/arch/powerpc/platforms/powernv/smp.c
> index e39e6c4..8d5b99e 100644
> --- a/arch/powerpc/platforms/powernv/smp.c
> +++ b/arch/powerpc/platforms/powernv/smp.c
> @@ -192,8 +192,16 @@ static void pnv_smp_cpu_kill_self(void)
>  		} else if ((idle_states & OPAL_PM_SLEEP_ENABLED) ||
>  			   (idle_states & OPAL_PM_SLEEP_ENABLED_ER1)) {
>  			srr1 = power7_sleep();
> -		} else {
> +		} else if (idle_states & OPAL_PM_NAP_ENABLED) {
>  			srr1 = power7_nap(1);
> +		} else {
> +			/* This is the fallback method. We emulate snooze */
> +			while (!generic_check_cpu_restart(cpu)) {
> +				HMT_low();
> +				HMT_very_low();
> +			}
> +			srr1 = 0;
> +			HMT_medium();
>  		}
>  
>  		ppc64_runlatch_on();

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] powernv:idle: Fixes for CPU-Hotplug on POWER DD1.0 "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-03-13 07:10 +0100
  [PATCH 2/3] powernv:idle: Don't override default/deepest directly in kernel "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-03-13 07:10 +0100
    Re: [PATCH 2/3] powernv:idle: Don't override default/deepest  directly in kernel Nicholas Piggin <npiggin@gmail.com> - 2017-03-14 15:10 +0100
      Re: [PATCH 2/3] powernv:idle: Don't override default/deepest  directly in kernel Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-03-15 12:20 +0100
  [PATCH 1/3] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-03-13 07:10 +0100
    Re: [PATCH 1/3] powernv:smp: Add busy-wait loop as fall back for  CPU-Hotplug Nicholas Piggin <npiggin@gmail.com> - 2017-03-14 14:40 +0100
  [PATCH 3/3] powernv:Recover correct PACA on wakeup from a stop on P9 DD1 "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-03-13 07:10 +0100
    Re: [PATCH 3/3] powernv:Recover correct PACA on wakeup from a stop  on P9 DD1 Nicholas Piggin <npiggin@gmail.com> - 2017-03-14 15:40 +0100

csiph-web