Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600290

RE: [PATCH 1/1] Drivers: hv: vmbus: Don't leak channel ids

Show all headers | View raw

> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of kys@exchange.microsoft.com
> 
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index e1a3ae4..0a85246 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgmt.c
> @@ -802,6 +802,7 @@ static void vmbus_onoffer(struct
> vmbus_channel_message_header *hdr)
>         /* Allocate the channel object and save this offer. */
>         newchannel = alloc_channel();
>         if (!newchannel) {
> +               vmbus_release_relid(offer->child_relid);
>                 pr_err("Unable to allocate channel object\n");
>                 return;
>         }

The patch seems good.

BTW,  vmbus_onoffer -> alloc_channel is only called in the workqueue
context, so maybe we should change the atomic kzalloc in alloc_channel
to GFP_KERNEL?

Thanks,
-- Dexuan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] Drivers: hv: vmbus: Don't leak channel ids kys@exchange.microsoft.com - 2017-03-14 00:00 +0100
  RE: [PATCH 1/1] Drivers: hv: vmbus: Don't leak channel ids Dexuan Cui <decui@microsoft.com> - 2017-03-14 13:50 +0100
    RE: [PATCH 1/1] Drivers: hv: vmbus: Don't leak channel ids KY Srinivasan <kys@microsoft.com> - 2017-03-14 15:40 +0100

csiph-web