Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count()

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count()
Date	2017-03-14 13:00 +0100
Message-ID	<tkTho-84x-9@gated-at.bofh.it> (permalink)
References	<tcYQW-6Uz-7@gated-at.bofh.it> <tcYQW-6Uz-11@gated-at.bofh.it> <tkRfA-6BP-23@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Mar 14, 2017 at 10:43:02AM +0100, Linus Walleij wrote:
> On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > It's unusual to have error checking like (ret <= 0) in cases when
> > counting GPIO resources. In case when it's mandatory we propagate the
> > error (-ENOENT), otherwise we don't use the result.
> >
> > This makes consistent behaviour across all possible variants called in
> > gpiod_count().
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Mika/Rafael, can you look at this patch?

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count() Linus Walleij <linus.walleij@linaro.org> - 2017-03-14 10:50 +0100
  Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count() Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-03-14 13:00 +0100

csiph-web