Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

From	Smitha T Murthy <smitha.t@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs
Date	2017-03-14 12:50 +0100
Message-ID	<tkT7I-7Za-13@gated-at.bofh.it> (permalink)
References	<tgRnQ-7or-27@gated-at.bofh.it> <tgRnR-7or-37@gated-at.bofh.it> <tgRnR-7or-35@gated-at.bofh.it> <timpA-7rg-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-03-07 at 13:08 +0100, Andrzej Hajda wrote: 
> On 03.03.2017 10:07, Smitha T Murthy wrote:
> > Added V4l2 controls for HEVC encoder
> 
> It should be rather "Document controls for HEVC encoder" or sth similar.
> 
> In general most of comments are in previous patch.
> Few additional comments:
> - please be careful about control names - they are exported to userspace
> and becomes ABI, so it will be difficult to change them later (this
> comment is rather to previous patch),
> - please provide good documentation as for most users this documentation
> will be the only available source of information,
> - in short: bugs in the driver can be easily fixed(usually), wrong
> control names will be hard to fix, weak documentation will prevent using it.
> 
> And regarding this patch:
> - please expand all acronyms (pb, tmv, BIT,...),
> - please consider using menu instead of numbers for profile, level,
> tier, types, generally everywhere where control value enumerates
> 'things' and is not a pure number (coefficient, counter,...),
> - if control is per-frame please drop it, V4L2 does not support it at
> the moment ( I suppose ),
> 
> Regards
> Andrzej
> 
> 
Ok I will change the patch description.
I will try to document each control more elaborately and check the
control names again. I do understand your concern regarding the wrong
documentation, I will try to make more understandable and helpful.
I will expand the macro names in the next version. I will
create a menu for controls where it is applicable.
Thank you so much for your review.

Regards,
Smitha 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy <smitha.t@samsung.com> - 2017-03-03 10:10 +0100
  Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs Andrzej Hajda <a.hajda@samsung.com> - 2017-03-07 13:30 +0100
    Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy <smitha.t@samsung.com> - 2017-03-14 12:50 +0100

csiph-web