Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600224

RE: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands

From David Laight <David.Laight@ACULAB.COM>
Newsgroups linux.kernel
Subject RE: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands
Date 2017-03-14 12:10 +0100
Message-ID <tkSv0-7ED-21@gated-at.bofh.it> (permalink)
References <tkIOZ-AW-3@gated-at.bofh.it> <tkIP0-AW-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: Doug Berger
> Sent: 14 March 2017 00:42
> This commit changes the ioctl handling behavior to return the
> EOPNOTSUPP error code instead of the EINVAL error code when an
> unknown ioctl command value is detected.
> 
> It also removes some redundant parsing of the ioctl command value
> and allows the SIOCSHWTSTAMP value to be handled.

A better description would seem to be:
Remove checks on ioctl command and just forward all ioctl requests
to phy_mii_ioctl().

I also thought the 'generic' response to an unknown ioctl command
was ENOTTY.

	David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands Doug Berger <opendmb@gmail.com> - 2017-03-14 01:50 +0100
  RE: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for  unknown ioctl commands David Laight <David.Laight@ACULAB.COM> - 2017-03-14 12:10 +0100
    Re: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for  unknown ioctl commands Doug Berger <opendmb@gmail.com> - 2017-03-14 18:40 +0100

csiph-web