Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c
Date	2017-03-14 12:00 +0100
Message-ID	<tkSlk-7kN-37@gated-at.bofh.it> (permalink)
References	<sfNot-7ju-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Michael Ellerman <mpe@ellerman.id.au> writes:

> We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it
> from electra_cf.c which is a powerpc-only driver.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  drivers/pcmcia/electra_cf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Ping anyone?

Or should I merge this via the powerpc tree?

cheers

> diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c
> index 4d7bc3f4124a..c6fe2a4a7a6a 100644
> --- a/drivers/pcmcia/electra_cf.c
> +++ b/drivers/pcmcia/electra_cf.c
> @@ -207,7 +207,7 @@ static int electra_cf_probe(struct platform_device *ofdev)
>  		return -ENOMEM;
>  
>  	setup_timer(&cf->timer, electra_cf_timer, (unsigned long)cf);
> -	cf->irq = NO_IRQ;
> +	cf->irq = 0;
>  
>  	cf->ofdev = ofdev;
>  	cf->mem_phys = mem.start;
> @@ -313,7 +313,7 @@ fail3:
>  fail2:
>  	release_mem_region(cf->mem_phys, cf->mem_size);
>  fail1:
> -	if (cf->irq != NO_IRQ)
> +	if (cf->irq)
>  		free_irq(cf->irq, cf);
>  
>  	if (cf->io_virt)
> -- 
> 2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Michael Ellerman <mpe@ellerman.id.au> - 2017-03-14 12:00 +0100
  Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Arnd Bergmann <arnd@arndb.de> - 2017-03-14 13:50 +0100
    Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Michael Ellerman <mpe@ellerman.id.au> - 2017-03-15 06:40 +0100
      Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Arnd Bergmann <arnd@arndb.de> - 2017-03-15 13:10 +0100
        Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Michael Ellerman <mpe@ellerman.id.au> - 2017-03-16 11:00 +0100
          Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Arnd Bergmann <arnd@arndb.de> - 2017-03-16 11:20 +0100
      Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Scott Wood <oss@buserror.net> - 2017-03-15 19:00 +0100
        Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c Michael Ellerman <mpe@ellerman.id.au> - 2017-03-16 11:10 +0100

csiph-web