Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600254
| Path | csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Alexander Kapshuk <alexander.kapshuk@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination |
| Date | Tue, 14 Mar 2017 12:40:03 +0100 |
| Message-ID | <tkSY3-7U6-45@gated-at.bofh.it> (permalink) |
| References | <tkSOl-7QC-15@gated-at.bofh.it> |
| X-Original-To | Pushkar Jambhlekar <pushkar.iit@gmail.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DbaoUXtbPmyszwE4Sx6GqVFI/1LbnvqV2vevU5ZzFyU=; b=BmWAsMlK8G6M3kr7DsGpEwh7tEAkFi5elMrup5lfk9hMz92krPwMMHZ/ymtJ8AfxsK IG29WQVKYDXp2i03BMkqEsmPqqVQynXZBS5uIkfAex3iayfUaRB47a8+91zApZd5wOBZ ZsQoQcclpoN4imIsptHliKXk/x2wwf+XOL1/9+EfBjAYqyC6GMRU42bdjS35dx+RVmxU 8Zj7kYMq0dO7lXkHoGXM5DBx898uUj27Pk2DBi3cANSIcFufUTNpA5uoHfqb2dYp//gt h2oclxTAtBDqQVIjqS85rEMbq4T7GXJdmiEeoNEEUmngTmc1khAtZT7CSyv0fJDU2Bf+ KATw== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DbaoUXtbPmyszwE4Sx6GqVFI/1LbnvqV2vevU5ZzFyU=; b=bKQfUvILwVuo2xDTma/1CA2BLd62j2FZXGlSBnId2oo4gbwziOwTWIN4CR0djY489S 94P4Q4aKOU0E3JBThpg9mx7FhEdpYKXpdq5T0ulB+TA5eHfE8bUBZwdesfkiz3UjT5H7 Qym+ILiAXrdixpD9S57ewYp82hAXD5mwSYv+WBH/k9B75yedlxmL5KwQOuTXfHqfeUM5 gzvL/qnQblxYT9W85kUxjx87tQ0nucFPbA5ydNw6YTz803P+EijQEYVTQrferneWXSb4 7egu/Xd+MeJ+5PoLSQ203WGDE+mJbNAh+FrSg/Ktqdctbcu/IeKg00gAvRc53ROeXD2Z gHag== |
| X-Gm-Message-State | AFeK/H2lJdIyl+kKW4IpdCLJzFvlY7Q09nAd/CfLYaIdsbcxzSYi6jBtruIgKfWMLLU+zMawzBXWsgM6P4tV2Q== |
| X-Received | by 10.36.253.194 with SMTP id m185mr14438501ith.76.1489491206540; Tue, 14 Mar 2017 04:33:26 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 26 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ivan Safonov <insafonov@gmail.com>, Yamanappagouda Patil <goudapatilk@gmail.com>, William Blough <devel@blough.us>, Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>, Kyle Kuffermann <kyle.kuffermann@gmail.com>, devel@driverdev.osuosl.org, linux-kernel <linux-kernel@vger.kernel.org> |
| X-Original-Date | Tue, 14 Mar 2017 13:32:46 +0200 |
| X-Original-Message-ID | <CAJ1xhMVNDPAZ8hv=SdBpju9hH5WK8Ex9GTtCMS6hWd-cOf20jA@mail.gmail.com> |
| X-Original-References | <1489490795-41996-1-git-send-email-pushkar.iit@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1600254 |
Show key headers only | View raw
On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar
<pushkar.iit@gmail.com> wrote:
> Description:
> There should not be ';' after do ... while(0) in macro defination
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index b283a490..5b1ef22 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -1690,4 +1690,4 @@ do { \
> d##1 = TE0(s##1) ^ TE1(s##2) ^ TE2(s##3) ^ TE3(s##0) ^ rk[4 * i + 1]; \
> d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^ rk[4 * i + 2]; \
> d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; \
> -} while (0);
> +} while (0)
> --
> 2.7.4
>
A semicolon is required after 'while(bool);' in 'do..while'.
Without it, you get a compile time error.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] rtl8188eu: Correcting macro ROUND macro defination Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-14 12:30 +0100
Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-03-14 12:40 +0100
Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-14 12:50 +0100
Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-03-14 13:00 +0100
Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-14 13:20 +0100
Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-14 13:20 +0100
csiph-web