Re: [PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues.

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues.
Date	2017-03-14 10:50 +0100
Message-ID	<tkRfA-6BP-9@gated-at.bofh.it> (permalink)
References	<tkMIV-3jk-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 13, 2017 at 09:52:14PM -0700, mshan wrote:
> Signed-off-by: mshan <mohsinshan1k@gmail.com>
> ---
>  drivers/staging/fwserial/fwserial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> index 41a49c8..d693c03 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -98,7 +98,7 @@ struct fwtty_transaction {
>  	};
>  };
>  
> -#define to_device(a, b)			(a->b)
> +#define to_device(a, b)			((a)->(b))

This macro is silly.  Just delete it.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues. mshan <educha997@gmail.com> - 2017-03-14 06:00 +0100
  Re: [PATCH] Fixed a minor coding style warning. Arguments in the  macros should be coverd in brackets to aviod any precedence issues. Greg KH <gregkh@linuxfoundation.org> - 2017-03-14 06:50 +0100
  Re: [PATCH] Fixed a minor coding style warning. Arguments in the  macros should be coverd in brackets to aviod any precedence issues. Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-14 10:50 +0100

csiph-web