Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600011
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] lockdep: call time_hardirqs_off after clearing hardirqs_enabled |
| Date | 2017-03-14 04:10 +0100 |
| Message-ID | <tkL0u-2gr-7@gated-at.bofh.it> (permalink) |
| References | <tkK4p-1BY-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 14 Mar 2017 10:00:07 +0800
Qi Hou <qi.hou@windriver.com> wrote:
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 577f026..e8b35e4 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2627,8 +2627,6 @@ __visible void trace_hardirqs_off_caller(unsigned long ip)
> {
> struct task_struct *curr = current;
>
> - time_hardirqs_off(CALLER_ADDR0, ip);
> -
> if (unlikely(!debug_locks || current->lockdep_recursion))
> return;
You do realize that this breaks irqsoff tracing if lockdep ever
triggers. Right?
-- Steve
>
> @@ -2649,6 +2647,8 @@ __visible void trace_hardirqs_off_caller(unsigned long ip)
> debug_atomic_inc(hardirqs_off_events);
> } else
> debug_atomic_inc(redundant_hardirqs_off);
> +
> + time_hardirqs_off(CALLER_ADDR0, ip);
> }
> EXPORT_SYMBOL(trace_hardirqs_off_caller);
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] lockdep: call time_hardirqs_off after clearing hardirqs_enabled Qi Hou <qi.hou@windriver.com> - 2017-03-14 03:10 +0100
Re: [PATCH] lockdep: call time_hardirqs_off after clearing hardirqs_enabled Steven Rostedt <rostedt@goodmis.org> - 2017-03-14 04:10 +0100
Re: [PATCH] lockdep: call time_hardirqs_off after clearing hardirqs_enabled Paul Gortmaker <paul.gortmaker@gmail.com> - 2017-03-14 04:10 +0100
Re: [PATCH] lockdep: call time_hardirqs_off after clearing hardirqs_enabled Thomas Gleixner <tglx@linutronix.de> - 2017-03-14 09:50 +0100
Re: [PATCH] lockdep: call time_hardirqs_off after clearing hardirqs_enabled qhou <qi.hou@windriver.com> - 2017-03-14 10:20 +0100
csiph-web