Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599993
| Path | csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Vinod Koul <vinod.koul@intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] engine: mv_xor: remove redundant null check on cd |
| Date | Tue, 14 Mar 2017 03:30:02 +0100 |
| Message-ID | <tkKnM-1IQ-3@gated-at.bofh.it> (permalink) |
| References | <tge38-4N8-25@gated-at.bofh.it> |
| X-Original-To | Colin King <colin.king@canonical.com> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.36,162,1486454400"; d="scan'208";a="75748142" |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 13 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 14 Mar 2017 08:00:40 +0530 |
| X-Original-Message-ID | <20170314023039.GY2843@localhost> |
| X-Original-References | <20170301140721.22341-1-colin.king@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1599993 |
Show key headers only | View raw
On Wed, Mar 01, 2017 at 02:07:21PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if cd is null is redundant, pdata->channels is
> never null at this point, and hence &pdata->channels[i] cannot
> be null, so remove the null check.
>
> Detected by CoverityScan, CID#1357194 ("Logically Dead Code")
Applied after fixing subsystem name
--
~Vinod
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] engine: mv_xor: remove redundant null check on cd Colin King <colin.king@canonical.com> - 2017-03-01 16:10 +0100 Re: [PATCH] engine: mv_xor: remove redundant null check on cd Vinod Koul <vinod.koul@intel.com> - 2017-03-14 03:30 +0100
csiph-web