Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599990
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usbnet: smsc95xx: Reduce logging noise |
| Date | 2017-03-14 03:20 +0100 |
| Message-ID | <tkKe6-1Fo-5@gated-at.bofh.it> (permalink) |
| References | <tjEkq-3VF-11@gated-at.bofh.it> <tkGNc-7uk-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/13/2017 03:32 PM, David Miller wrote: > From: Guenter Roeck <linux@roeck-us.net> > Date: Fri, 10 Mar 2017 17:45:21 -0800 > >> An insert/remove stress test generated the following log message sequence. > ... >> Use netdev_dbg() instead of netdev_warn() for the repeating messages >> to reduce logging noise. >> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > The problem I have with changes like this is that outside of your > stress test situation these messages are extremely useful but will > now be hidden making diagnosis of problems more difficult. > In general I agree, but in this case the calling code also generates another set of error messages, which I considered a bit excessive. No problem, though, we can live with the noise. Guenter
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] usbnet: smsc95xx: Reduce logging noise Guenter Roeck <linux@roeck-us.net> - 2017-03-11 02:50 +0100
Re: [PATCH] usbnet: smsc95xx: Reduce logging noise David Miller <davem@davemloft.net> - 2017-03-13 23:40 +0100
Re: [PATCH] usbnet: smsc95xx: Reduce logging noise Guenter Roeck <linux@roeck-us.net> - 2017-03-14 03:20 +0100
csiph-web