[PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work

From	Masaki Ota <012nexus@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work
Date	2017-03-14 02:40 +0100
Message-ID	<tkJBo-1aD-7@gated-at.bofh.it> (permalink)
References	<tkJBo-1aD-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Masaki Ota <masaki.ota@jp.alps.com>
- V8 Button pad Stick Right and Middle button don't work.
- Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process.

Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com>

Acked-by: Pali Rohar <pali.rohar@gmail.com>
---
 drivers/input/mouse/alps.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 253f742..262d105 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -1287,10 +1287,8 @@ static int alps_decode_ss4_v2(struct alps_fields *f,
 	/* handle buttons */
 	if (pkt_id == SS4_PACKET_ID_STICK) {
 		f->ts_left = !!(SS4_BTN_V2(p) & 0x01);
-		if (!(priv->flags & ALPS_BUTTONPAD)) {
-			f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
-			f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
-		}
+		f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
+		f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
 	} else {
 		f->left = !!(SS4_BTN_V2(p) & 0x01);
 		if (!(priv->flags & ALPS_BUTTONPAD)) {
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work Masaki Ota <012nexus@gmail.com> - 2017-03-14 02:40 +0100
  Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does  not work Paul Donohue <linux-kernel@paulsd.com> - 2017-03-14 16:00 +0100
  Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does  not work Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-17 22:30 +0100

csiph-web