Re: [PATCH 1/2] staging: wlan-ng: introduce a macro read_u16

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] staging: wlan-ng: introduce a macro read_u16
Date	2017-03-14 01:10 +0100
Message-ID	<tkIch-iT-7@gated-at.bofh.it> (permalink)
References	<tky3g-12m-9@gated-at.bofh.it> <tky3g-12m-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 13, 2017 at 02:14:25PM +0100, Gioh Kim wrote:
> read_u16 is wrapper of le16_to_cpu to read u16 variable,
> rather than __le16.
> 
> Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 88b979f..97ede25 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -63,6 +63,9 @@
>  extern int prism2_reset_holdtime;
>  extern int prism2_reset_settletime;
>  
> +#define read_u16(x) ({ u32 __r = (u32)le16_to_cpu((__force __le16)(x)); \
> +			__r; })
> +

Eeek, no, this should not be needed at all, if the code is written
correctly.  Please fix things up to work properly, don't paper over them
with forced casts.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: wlan-ng: introduce a macro read_u16 Gioh Kim <gi-oh.kim@profitbricks.com> - 2017-03-13 14:20 +0100
  Re: [PATCH 1/2] staging: wlan-ng: introduce a macro read_u16 Greg KH <gregkh@linuxfoundation.org> - 2017-03-14 01:10 +0100

csiph-web