Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599945
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Doug Berger <opendmb@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts |
| Date | Tue, 14 Mar 2017 01:50:01 +0100 |
| Message-ID | <tkIOZ-AW-11@gated-at.bofh.it> (permalink) |
| References | <tkIOZ-AW-3@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fJmjEAQxIZx0ic/Ptm2wxDt5uUiVYp6mQYhcZnx6tis=; b=YRZj1rhQs8Qlow6Pw+tYkMWb6vN1/ctdPPGQ2VhZt52TkWci3s1dxqTCbWGsy8mkp5 UpBZoB/oMZt2GG7hfJUSvaPM34ClEhLTwhqpupJl8KCgwqK/1aZpSVjIxVMFOHQY1eCb ehy94RfKoSLNuz5k7k3S3wKisTyl3qqkVNXgvAjDRSlV02npl5tqwDfZmdul33ZIaCVV VhsG/GJ4PSpwN14T8N2G8fhJtbdulIGzIcF9Ufbj+k5Sq3WD0GZqb+TCSXb02FoVAJS8 J7iM7UKNYPkADbskHHDUEpw4eQW+p/xEt5GkWaWDjDbYv8XlFIw9YqzO7DBw/5byZ3Tv t2YA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fJmjEAQxIZx0ic/Ptm2wxDt5uUiVYp6mQYhcZnx6tis=; b=XsNOxcyZw2IQxeKaE20JEo8gumMz3bllb5Oc1w4wERfU76ePcpck4gHddZRGhmVKSH lFgk7Tt4Czcurpw/wla+7aGUO8r+r4pfhH37ZjETiTStE1Eh/AhHoSlLzVRSBISY7RF7 tZ6Aof463AK9PLkfE9eA1tHwyvPJYhxZPCcaBpldry4EhYLBU8sc9tFJWT6ZhvZY3YA0 pUI+kuAUMflI0ts8m1VTx0n3rP2HQlo7nUrbtP4AQIjgiWW7Dd/21NuORgGRXo9Le4s5 gk/R6fthpwYEb4jd8OOthbRBZ85t3o3zWWFTEyR61kG5fOywhjrGiuWkdeFQzYMaeA1/ t+hg== |
| X-Gm-Message-State | AMke39mqlV/tuzC2ikjJWfZ64AYPs17PPrS4Lnaw9GTArQTac/H9YVzYI5ffMjnr4/KIUQ== |
| X-Received | by 10.200.51.152 with SMTP id c24mr38070101qtb.31.1489452138176; Mon, 13 Mar 2017 17:42:18 -0700 (PDT) |
| X-Mailer | git-send-email 2.11.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 56 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | robh+dt@kernel.org, mark.rutland@arm.com, davem@davemloft.net, rafal@milecki.pl, xow@google.com, joel@jms.id.au, jon.mason@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pgynther@google.com, jaedon.shin@gmail.com, Doug Berger <opendmb@gmail.com> |
| X-Original-Date | Mon, 13 Mar 2017 17:41:37 -0700 |
| X-Original-Message-ID | <20170314004142.4746-8-opendmb@gmail.com> |
| X-Original-References | <20170314004142.4746-1-opendmb@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1599945 |
Show key headers only | View raw
Since the DMA interrupt status is latched and the DMA servicing can be
polled, it is a good idea to clear the latched status of a DMA interrupt
before performing the service that would be invoked by the interrupt.
This prevents old status from causing spurious interrupts when the
interrupt is unmasked at a later time.
Signed-off-by: Doug Berger <opendmb@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 661ca1b39c89..1f94ba1773dd 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -1174,6 +1174,14 @@ static unsigned int __bcmgenet_tx_reclaim(struct net_device *dev,
unsigned int txbds_ready;
unsigned int txbds_processed = 0;
+ /* Clear status before servicing to reduce spurious interrupts */
+ if (ring->index == DESC_INDEX)
+ bcmgenet_intrl2_0_writel(priv, UMAC_IRQ_TXDMA_DONE,
+ INTRL2_CPU_CLEAR);
+ else
+ bcmgenet_intrl2_1_writel(priv, (1 << ring->index),
+ INTRL2_CPU_CLEAR);
+
/* Compute how many buffers are transmitted since last xmit call */
c_index = bcmgenet_tdma_ring_readl(priv, ring->index, TDMA_CONS_INDEX)
& DMA_C_INDEX_MASK;
@@ -1584,10 +1592,21 @@ static unsigned int bcmgenet_desc_rx(struct bcmgenet_rx_ring *ring,
unsigned long dma_flag;
int len;
unsigned int rxpktprocessed = 0, rxpkttoprocess;
- unsigned int p_index;
+ unsigned int p_index, mask;
unsigned int discards;
unsigned int chksum_ok = 0;
+ /* Clear status before servicing to reduce spurious interrupts */
+ if (ring->index == DESC_INDEX) {
+ bcmgenet_intrl2_0_writel(priv, UMAC_IRQ_RXDMA_DONE,
+ INTRL2_CPU_CLEAR);
+ } else {
+ mask = 1 << (UMAC_IRQ1_RX_INTR_SHIFT + ring->index);
+ bcmgenet_intrl2_1_writel(priv,
+ mask,
+ INTRL2_CPU_CLEAR);
+ }
+
p_index = bcmgenet_rdma_ring_readl(priv, ring->index, RDMA_PROD_INDEX);
discards = (p_index >> DMA_P_INDEX_DISCARD_CNT_SHIFT) &
--
2.11.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts Doug Berger <opendmb@gmail.com> - 2017-03-14 01:50 +0100 Re: [PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts Florian Fainelli <f.fainelli@gmail.com> - 2017-03-14 02:00 +0100
csiph-web