Re: [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary
Date	2017-03-14 00:30 +0100
Message-ID	<tkHzz-8bx-1@gated-at.bofh.it> (permalink)
References	<tkHzz-8bx-3@gated-at.bofh.it> <tkwkN-8ew-5@gated-at.bofh.it>
Organization	Samsung Electronics

Show all headers | View raw

Hi,

On 2017년 03월 13일 20:28, Hans de Goede wrote:
> With the new more strict ACPI gpio code the dsdt's IoRestriction
> flags are honored on gpiod_get, but in some dsdt's it is wrong,
> so explicitly call gpiod_direction_input on the id gpio if
> necessary.
> 
> This fixes the following errors when the int3496 code is used
> together with the new more strict ACPI gpio code:
> 
> [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
> [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ
> [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio
> [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22
> [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22
> 
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Warn about firmware bug when the dsdt's IoRestriction does not allow input
> Changes in v3:
> -Use FW_BUG macro
> -Group check together with gpiodesc error check
> -Keep lines within 80 chars limit
> ---
>  drivers/extcon/extcon-intel-int3496.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary Hans de Goede <hdegoede@redhat.com> - 2017-03-13 12:30 +0100
  Re: [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 12:50 +0100
  Re: [PATCH v3] extcon: int3496: Set the id pin to direction-input if  necessary Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-14 00:30 +0100

csiph-web