Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1599889

Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable
Date Mon, 13 Mar 2017 23:30:02 +0100
Message-ID <tkGDw-7lk-7@gated-at.bofh.it> (permalink)
References <tkcYN-2Pm-9@gated-at.bofh.it>
X-Original-To Daeseok Youn <daeseok.youn@gmail.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.8.0 (2017-02-23)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 15
Organization linux.* mail to news gateway
X-Original-Cc lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Tue, 14 Mar 2017 06:26:11 +0800
X-Original-Message-ID <20170313222611.GA23550@kroah.com>
X-Original-References <20170312144727.GA24031@jyoun-Latitude-E6530>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1599889

Show key headers only | View raw


On Sun, Mar 12, 2017 at 11:47:28PM +0900, Daeseok Youn wrote:
> The bd variable in dgnc_tty_digiseta() is assigned with
> ch->ch_bd but it is not used in this function except checking NULL.
> The ch->ch_bd could be replaced with bd variable in dgnc_tty_digiseta()
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please merge this with your first patch in the series and resend them.

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd  variable Daeseok Youn <daeseok.youn@gmail.com> - 2017-03-12 15:50 +0100
  Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd  variable Greg KH <gregkh@linuxfoundation.org> - 2017-03-13 23:30 +0100
    Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable DaeSeok Youn <daeseok.youn@gmail.com> - 2017-03-14 02:50 +0100

csiph-web