Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1599811
| From | Chris Packham <Chris.Packham@alliedtelesis.co.nz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm, gup: fix typo in gup_p4d_range() |
| Date | 2017-03-13 22:00 +0100 |
| Message-ID | <tkFer-63w-53@gated-at.bofh.it> (permalink) |
| References | <tkqIp-46N-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 13/03/17 18:22, Kirill A. Shutemov wrote:
> gup_p4d_range() should call gup_pud_range(), not itself.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reported-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Fixes: c2febafc6773 ("mm: convert generic code to 5-level paging")
> ---
> mm/gup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index c74bad1bf6e8..04aa405350dc 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1455,7 +1455,7 @@ static int gup_p4d_range(pgd_t pgd, unsigned long addr, unsigned long end,
> if (!gup_huge_pd(__hugepd(p4d_val(p4d)), addr,
> P4D_SHIFT, next, write, pages, nr))
> return 0;
> - } else if (!gup_p4d_range(p4d, addr, next, write, pages, nr))
> + } else if (!gup_pud_range(p4d, addr, next, write, pages, nr))
> return 0;
> } while (p4dp++, addr = next, addr != end);
Fixes the build issue for me. Thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm, gup: fix typo in gup_p4d_range() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-03-13 06:30 +0100 Re: [PATCH] mm, gup: fix typo in gup_p4d_range() Michal Hocko <mhocko@kernel.org> - 2017-03-13 10:10 +0100 Re: [PATCH] mm, gup: fix typo in gup_p4d_range() Mark Rutland <mark.rutland@arm.com> - 2017-03-13 15:20 +0100 Re: [PATCH] mm, gup: fix typo in gup_p4d_range() Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-03-13 22:00 +0100 Re: [PATCH] mm, gup: fix typo in gup_p4d_range() Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-14 19:40 +0100
csiph-web