Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1599841

Re: [PATCH] PM / QOS: Remove the global notifiers

From Kevin Hilman <khilman@baylibre.com>
Newsgroups linux.kernel
Subject Re: [PATCH] PM / QOS: Remove the global notifiers
Date 2017-03-13 22:40 +0100
Message-ID <tkFR7-6IY-11@gated-at.bofh.it> (permalink)
References <tdAtc-7g0-19@gated-at.bofh.it> <tkAHL-2Z7-13@gated-at.bofh.it> <tkAHL-2Z7-11@gated-at.bofh.it>
Organization BayLibre

Show all headers | View raw


Ulf Hansson <ulf.hansson@linaro.org> writes:

> On 13 March 2017 at 17:01, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 22 February 2017 at 09:28, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>> They were never used in the kernel, not sure why they got merged into
>>> the kernel though. Get rid of them.
>>
>> commit b66213cdb002b08b29603d488c451dfe25e2ca20
>> Author: Jean Pihet <j-pihet@ti.com>
>> Date:   Thu Aug 25 15:35:47 2011 +0200
>>
>>     PM QoS: Add global notification mechanism for device constraints
>>
>>     Add a global notification chain that gets called upon changes to the
>>     aggregated constraint value for any device.
>>     The notification callbacks are passing the full constraint request data
>>     in order for the callees to have access to it. The current use is for the
>>     platform low-level code to access the target device of the constraint.
>>
>>     Signed-off-by: Jean Pihet <j-pihet@ti.com>
>>     Reviewed-by: Kevin Hilman <khilman@ti.com>
>>     Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>>
>> It was a while ago since they were added, but it seems like
>
> Slipped on the keyboard, sorry for the noise.
>
> I was about to say, that it was a while ago these were added, but
> still not being used. Thus let's remove them.
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Agreed.  If we still have no users, let's remove them.

Acked-by: Kevin Hilman <khilman@baylibre.com>

Kevin

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] PM / QOS: Remove the global notifiers Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-13 17:10 +0100
  Re: [PATCH] PM / QOS: Remove the global notifiers Kevin Hilman <khilman@baylibre.com> - 2017-03-13 22:40 +0100
    Re: [PATCH] PM / QOS: Remove the global notifiers Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-14 04:10 +0100

csiph-web